Issue 1961133004: MD Settings: Add remaining buttons to keyboard subpage

Issue 1961133004: MD Settings: Add remaining buttons to keyboard subpage (Closed)

Created:
4 years, 7 months ago by michaelpg

Modified:
4 years, 7 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

MD Settings: Add remaining buttons to keyboard subpage BUG=546834 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/0cce975e66d3d9167b5ba5dd86b50fe0141da79a Cr-Commit-Position: refs/heads/master@{#392658}

Patch Set 1 #

Patch Set 2 : closure #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -5 lines)			Patch
M	chrome/app/settings_strings.grdp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/settings/device_page/compiled_resources2.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/settings/device_page/device_page.html	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/settings/device_page/device_page_browser_proxy.js	View	1	2 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/settings/device_page/keyboard.html	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/settings/device_page/keyboard.js	View		3 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/webui/settings/device_page_tests.js	View		3 chunks	+18 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1967913002 Patch 1

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961133004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961133004/40001

4 years, 7 months ago (2016-05-10 17:17:19 UTC) #6

commit-bot: I haz the power

4 years, 7 months ago (2016-05-10 18:31:40 UTC) #9

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/0cce975e66d3d9167b5ba5dd86b50fe0141da79a
Cr-Commit-Position: refs/heads/master@{#392658}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages