Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10606)

Unified Diff: chrome/test/data/webui/settings/device_page_tests.js

Issue 1961133004: MD Settings: Add remaining buttons to keyboard subpage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: closure Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/device_page_tests.js
diff --git a/chrome/test/data/webui/settings/device_page_tests.js b/chrome/test/data/webui/settings/device_page_tests.js
index 1860fd7caa611bd30ced12ae4d769b136e805b8b..0be90aaacd90b8ce6acc4116de558fdd5a888340 100644
--- a/chrome/test/data/webui/settings/device_page_tests.js
+++ b/chrome/test/data/webui/settings/device_page_tests.js
@@ -7,7 +7,9 @@ cr.define('settings_device_page', function() {
* @constructor
* @implements {settings.DevicePageBrowserProxy}
*/
- function TestDevicePageBrowserProxy() {}
+ function TestDevicePageBrowserProxy() {
+ this.keyboardShortcutsOverlayShown_ = 0;
+ }
TestDevicePageBrowserProxy.prototype = {
/** @override */
@@ -17,6 +19,14 @@ cr.define('settings_device_page', function() {
// Prevent opening the link, which can block the test.
e.preventDefault();
},
+
+ /** override */
+ initializeKeyboard: function() {},
+
+ /** override */
+ showKeyboardShortcutsOverlay: function() {
+ this.keyboardShortcutsOverlayShown_++;
+ },
};
suite('SettingsDevicePage', function() {
@@ -240,6 +250,13 @@ cr.define('settings_device_page', function() {
devicePage.set(
'prefs.settings.language.xkb_auto_repeat_enabled_r2.value', false);
expectFalse(collapse.opened);
+
+ // Test keyboard shortcut overlay button.
+ MockInteractions.tap(keyboardPage.$$('#keyboardOverlay'));
+ expectEquals(
+ 1,
+ settings.DevicePageBrowserProxyImpl.getInstance()
+ .keyboardShortcutsOverlayShown_);
});
// Test more edge cases for slider rounding logic.
« no previous file with comments | « chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698