Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: ios/testing/earl_grey/wait_util.h

Issue 1961063002: Add web shell matcher for address field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/testing/earl_grey/wait_util.h
diff --git a/ios/testing/earl_grey/wait_util.h b/ios/testing/earl_grey/wait_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..6c77ff9e8d01fa5cfb8553c4326311ae9cd60eee
--- /dev/null
+++ b/ios/testing/earl_grey/wait_util.h
@@ -0,0 +1,12 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+namespace earl_grey_support {
Eugene But (OOO till 7-30) 2016/05/09 15:59:08 Can be changed later. Everything which lives in i
baxley 2016/05/09 17:11:42 That's reasonable. Done.
+
+// Constant for UI wait loop in seconds.
+const NSTimeInterval kSpinDelaySeconds = 0.01;
Eugene But (OOO till 7-30) 2016/05/09 15:59:08 These should be extern. No?
baxley 2016/05/09 17:11:42 Done.
+
+// Constant for timeout in seconds while waiting for web element.
Eugene But (OOO till 7-30) 2016/05/09 15:59:08 Can be changed later. Sounds like this should be
baxley 2016/05/09 17:11:43 The code matched my intention, but the comment is
Eugene But (OOO till 7-30) 2016/05/09 17:58:34 I see. Then kWaitForUIElementTimeout :)
+const NSTimeInterval kWaitForElementTimeout = 4.0;
Eugene But (OOO till 7-30) 2016/05/09 15:59:08 kWaitForWebElementTimeout
baxley 2016/05/09 17:11:42 see previous comment.
+}

Powered by Google App Engine
This is Rietveld 408576698