ios/testing/earl_grey/wait_util.h - Issue 1961063002: Add web shell matcher for address field.

Side by Side Diff: ios/testing/earl_grey/wait_util.h

Issue 1961063002: Add web shell matcher for address field. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ios/testing/earl_grey/earl_grey_support.gyp ('K') | « ios/testing/earl_grey/earl_grey_support.gyp ('k') | ios/web/ios_web_shell_tests.gyp » ('j') | ios/web/shell/test/earl_grey/shell_matchers.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 namespace earl_grey_support {
	Eugene But (OOO till 7-30) 2016/05/09 15:59:08 Can be changed later. Everything which lives in i Can be changed later. Everything which lives in ios/web is namespaced as web::, everything that lives in ios/net is namespaced as net::. With that I feel that the namespace should be testing. WDYT? baxley 2016/05/09 17:11:42 That's reasonable. Done. Show quoted text On 2016/05/09 15:59:08, Eugene But wrote: > Can be changed later. > > Everything which lives in ios/web is namespaced as web::, everything that lives > in ios/net is namespaced as net::. > > With that I feel that the namespace should be testing. WDYT? That's reasonable. Done.
	6

	7 // Constant for UI wait loop in seconds.

	8 const NSTimeInterval kSpinDelaySeconds = 0.01;
	Eugene But (OOO till 7-30) 2016/05/09 15:59:08 These should be extern. No? These should be extern. No? baxley 2016/05/09 17:11:42 Done. Show quoted text On 2016/05/09 15:59:08, Eugene But wrote: > These should be extern. No? Done.
	9

	10 // Constant for timeout in seconds while waiting for web element.
	Eugene But (OOO till 7-30) 2016/05/09 15:59:08 Can be changed later. Sounds like this should be Can be changed later. Sounds like this should be a part of ios/web/test, not ios/testing baxley 2016/05/09 17:11:43 The code matched my intention, but the comment is Show quoted text On 2016/05/09 15:59:08, Eugene But wrote: > Can be changed later. > > Sounds like this should be a part of ios/web/test, not ios/testing The code matched my intention, but the comment is wrong. I left the code as is, and updated the comment. My intention is for these delays to not be web specific. For example, shell_matchers is waiting for the address text to be updated, and nothing in the web. The web does affect this, but it's a matcher for non web UI. This could also be used by Chrome, as the default UI wait when we need to poll. If the core reason for any delay is the web, I'm fine with moving it to web/public/test. But I don't know if we can guarantee web stuff is the only thing that will need this. What do you think? Eugene But (OOO till 7-30) 2016/05/09 17:58:34 I see. Then kWaitForUIElementTimeout :) Show quoted text On 2016/05/09 17:11:43, baxley wrote: > On 2016/05/09 15:59:08, Eugene But wrote: > > Can be changed later. > > > > Sounds like this should be a part of ios/web/test, not ios/testing > > The code matched my intention, but the comment is wrong. I left the code as is, > and updated the comment. My intention is for these delays to not be web > specific. For example, shell_matchers is waiting for the address text to be > updated, and nothing in the web. The web does affect this, but it's a matcher > for non web UI. This could also be used by Chrome, as the default UI wait when > we need to poll. > > If the core reason for any delay is the web, I'm fine with moving it to > web/public/test. But I don't know if we can guarantee web stuff is the only > thing that will need this. What do you think? I see. Then kWaitForUIElementTimeout :)
	11 const NSTimeInterval kWaitForElementTimeout = 4.0;
	Eugene But (OOO till 7-30) 2016/05/09 15:59:08 kWaitForWebElementTimeout kWaitForWebElementTimeout baxley 2016/05/09 17:11:42 see previous comment. Show quoted text On 2016/05/09 15:59:08, Eugene But wrote: > kWaitForWebElementTimeout see previous comment.
	12 }

OLD	NEW