Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1960993002: [X87] [Ignition] Fix V8 x87 code generation bugs when Ingition was enabled. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[X87] [Ignition] Fix V8 x87 code generation bugs when Ingition was enabled. The CL #35926 (https://codereview.chromium.org/1804003002) exposed two hidden bugs in x87 code generation when Ignition was enabled. This CL fixed those bugs. BUG= Committed: https://crrev.com/38ec29b4a38e6e285773208b8306c1f653120955 Cr-Commit-Position: refs/heads/master@{#36099}

Patch Set 1 #

Patch Set 2 : format the comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-09 06:22:38 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-09 08:16:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960993002/20001
4 years, 7 months ago (2016-05-09 08:18:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 08:46:38 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 08:47:19 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38ec29b4a38e6e285773208b8306c1f653120955
Cr-Commit-Position: refs/heads/master@{#36099}

Powered by Google App Engine
This is Rietveld 408576698