MD Settings: remove shadow from drawer in narrow mode, change font color

MD Settings: remove shadow from drawer in narrow mode, change font color

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c549bc02989c26fd72c3e8c1f9268444e41f1a56
Cr-Commit-Position: refs/heads/master@{#392788}

[Dan Beam, 2016-05-10 00:54:24]

Description was changed from

==========
MD Settings: remove shadow from drawer in narrow mode, change font color

R=dschuyler@chromium.org
BUG=608519
==========

to

==========
MD Settings: remove shadow from drawer in narrow mode, change font color

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-05-10 20:51:59]

lgtm

[Dan Beam, 2016-05-10 20:54:55]

dschuyler@: did you see patchset #2?

[dschuyler, 2016-05-10 21:28:01]

On 2016/05/10 20:54:55, Dan Beam wrote:
> dschuyler@: did you see patchset #2?

It turns out that I accidentally reviewed patch #1 only.

SLGTM, though I have a question or two in the comments
that may (slight chance) be helpful, but are likely just
for my education.

[dschuyler, 2016-05-10 23:07:46]

https://codereview.chromium.org/1960983004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1960983004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.html:49: display:
block;
Are the content and display entries needed?
I'm wondering if the content can be '' rather
than a space or omitted entirely(?).

Does the ::after subtly remove a display:block
from elsewhere that this is restoring or is it
doing something else?

[Dan Beam, 2016-05-10 23:34:27]

https://codereview.chromium.org/1960983004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_ui/settings_ui.html (right):

https://codereview.chromium.org/1960983004/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_ui/settings_ui.html:49: display:
block;
On 2016/05/10 23:07:44, dschuyler wrote:
> Are the content and display entries needed?

yes

> I'm wondering if the content can be '' rather
> than a space or omitted entirely(?).

Done. (as '')

> 
> Does the ::after subtly remove a display:block
> from elsewhere that this is restoring or is it
> doing something else?

https://developer.mozilla.org/en-US/docs/Web/CSS/::after

[Dan Beam, 2016-05-10 23:35:16]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-05-10 23:35:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dschuyler@chromium.org
Link to the patchset: https://codereview.chromium.org/1960983004/#ps60001
(title: "empty content")

[commit-bot: I haz the power, 2016-05-10 23:35:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960983004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960983004/60001

[commit-bot: I haz the power, 2016-05-11 00:36:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 00:37:39]

Description was changed from

==========
MD Settings: remove shadow from drawer in narrow mode, change font color

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: remove shadow from drawer in narrow mode, change font color

R=dschuyler@chromium.org
BUG=608519
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c549bc02989c26fd72c3e8c1f9268444e41f1a56
Cr-Commit-Position: refs/heads/master@{#392788}
==========

[commit-bot: I haz the power, 2016-05-11 00:37:40]

Patchset 4 (id:??) landed as
https://crrev.com/c549bc02989c26fd72c3e8c1f9268444e41f1a56
Cr-Commit-Position: refs/heads/master@{#392788}