Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6039)

Unified Diff: chrome/browser/resources/settings/settings_ui/settings_ui.html

Issue 1960983004: MD Settings: remove shadow from drawer in narrow mode, change font color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: empty content Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_ui/settings_ui.html
diff --git a/chrome/browser/resources/settings/settings_ui/settings_ui.html b/chrome/browser/resources/settings/settings_ui/settings_ui.html
index 36d253ddb47988ac6b9bfdedf87a54b3cc276371..641460ccf582def582061f69d060e58685200c29 100644
--- a/chrome/browser/resources/settings/settings_ui/settings_ui.html
+++ b/chrome/browser/resources/settings/settings_ui/settings_ui.html
@@ -33,23 +33,47 @@
}
#drawer {
+ --paper-header-panel-shadow: {
+ /* Polymer's style transformation chokes on :host() and :not() (and
+ * many other things, it seems). Just hide the built-in shadow and
+ * duplicate its style. */
+ display: none;
+ };
/* Explicitly set this so that transitions work and look good. */
background-color: var(--settings-background-color);
}
+ #drawer .toolbar::after {
+ box-shadow: inset 0px 5px 6px -3px rgba(0, 0, 0, 0.4);
+ content: '';
+ display: block;
+ height: 6px;
+ }
+
#drawer,
- #drawer .toolbar {
- transition: background-color .3s, color .3s;
+ #drawer .toolbar,
+ #drawer .toolbar::after {
+ transition: background-color .3s, color .3s, height .3s;
+ }
+
+ :host(:not(.narrowing)) [narrow] #drawer,
+ :host(:not(.narrowing)) [narrow] #drawer .toolbar,
+ :host(:not(.narrowing)) [narrow] #drawer .toolbar::after {
+ transition: none; /* Transition only when removing [narrow]. */
}
:host(:not(.narrowing)) [narrow] #drawer,
:host(:not(.narrowing)) [narrow] #drawer .toolbar {
background-color: white;
- transition: none; /* Transition only when removing [narrow]. */
}
:host(:not(.narrowing)) [narrow] #drawer .toolbar {
- color: black;
+ color: var(--settings-nav-grey);
+ }
+
+ :host(:not(.narrowing)) [narrow] #drawer .toolbar::after {
+ border-bottom: var(--settings-separator-line);
+ height: 0;
}
paper-icon-button {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698