Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 196093002: Remove document param from parseSystemColor (Closed)

Created:
6 years, 9 months ago by rwlbuis
Modified:
6 years, 9 months ago
CC:
blink-reviews, aandrey+blink_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, Rik, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove document param from parseSystemColor The document parameter was introduced in http://trac.webkit.org/changeset/78442 because it was needed to get to the system colors. However this now can be accessed using a RenderTheme singleton so remove the parameter. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169063

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -14 lines) Patch
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasStyle.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
Further refactoring, I think a lot more can be done in the css parser area...
6 years, 9 months ago (2014-03-12 15:30:44 UTC) #1
abarth-chromium
lgtm Nice!
6 years, 9 months ago (2014-03-12 19:31:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/196093002/1
6 years, 9 months ago (2014-03-12 19:36:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-12 20:14:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_blink_compile
6 years, 9 months ago (2014-03-12 20:14:41 UTC) #5
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 9 months ago (2014-03-12 20:24:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/196093002/1
6 years, 9 months ago (2014-03-12 20:24:12 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-12 22:13:14 UTC) #8
Message was sent while issue was closed. 
Change committed as 169063

Powered by Google App Engine
This is Rietveld 408576698