Source/core/css/parser/BisonCSSParser-in.cpp - Issue 196093002: Remove document param from parseSystemColor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 196093002: Remove document param from parseSystemColor (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/parser/BisonCSSParser-in.cpp

diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp

index 543bc20b8f8fb1c411efc193e5c87e15f8d8d7c6..782a8870c9c433184759090e3168c002e8bc1ded 100644

--- a/Source/core/css/parser/BisonCSSParser-in.cpp

+++ b/Source/core/css/parser/BisonCSSParser-in.cpp

@@ -1124,11 +1124,8 @@ bool BisonCSSParser::parseColor(const String& string)

return !m_parsedProperties.isEmpty() && m_parsedProperties.first().id() == CSSPropertyColor;

}

-bool BisonCSSParser::parseSystemColor(RGBA32& color, const String& string, Document* document)

+bool BisonCSSParser::parseSystemColor(RGBA32& color, const String& string)

{

- if (!document)

- return false;

CSSParserString cssColor;

cssColor.init(string);

CSSValueID id = cssValueKeywordID(cssColor);