Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1960923003: Revert of [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. (Closed)

Created:
4 years, 7 months ago by gsennton
Modified:
4 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. (patchset #1 id:1 of https://codereview.chromium.org/1950943002/ ) Reason for revert: Fix WebViewLayoutTest failures due to https://codereview.chromium.org/1380503002 being reverted. Thus, to fix this we need to revert the current CL and https://codereview.chromium.org/1951253003 BUG=609448 Original issue's description: > [Sheriff] Fix WebViewLayoutTest regarding global interface expectations. > > The expectation file assume speechSynthesis is an attribute but its now > a getter. > > BUG=609100 > R=timvolodine@chromium.org > > Committed: https://crrev.com/e3168773cb69e2a78acce39d1b4c1adbf56cac87 > Cr-Commit-Position: refs/heads/master@{#391504} TBR=timvolodine@chromium.org,mlamouri@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=609100 Committed: https://crrev.com/a4497b8860b781fa97da812edfbffa64ef27f1e4 Cr-Commit-Position: refs/heads/master@{#392335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
gsennton
Created Revert of [Sheriff] Fix WebViewLayoutTest regarding global interface expectations.
4 years, 7 months ago (2016-05-09 16:02:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960923003/1
4 years, 7 months ago (2016-05-09 16:02:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 16:34:48 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 16:36:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4497b8860b781fa97da812edfbffa64ef27f1e4
Cr-Commit-Position: refs/heads/master@{#392335}

Powered by Google App Engine
This is Rietveld 408576698