Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1951253003: [WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. (Closed)

Created:
4 years, 7 months ago by timvolodine
Modified:
4 years, 7 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebViewShellLayoutTest] Fix AOSP bots failure testWebViewExcludedInterfaces. Fix exclude list due to https://codereview.chromium.org/1380503002 Should fix WebView L and WebView M AOSP bots. BUG=608979, 609448 Committed: https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9 Cr-Commit-Position: refs/heads/master@{#391803}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
timvolodine
4 years, 7 months ago (2016-05-05 14:09:22 UTC) #3
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1951253003/diff/1/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt File android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt (left): https://codereview.chromium.org/1951253003/diff/1/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt#oldcode66 android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt:66: attribute speechSynthesis didn't that land already?
4 years, 7 months ago (2016-05-05 14:11:59 UTC) #4
timvolodine
https://codereview.chromium.org/1951253003/diff/1/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt File android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt (left): https://codereview.chromium.org/1951253003/diff/1/android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt#oldcode66 android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt:66: attribute speechSynthesis On 2016/05/05 14:11:58, Mounir Lamouri wrote: > ...
4 years, 7 months ago (2016-05-05 14:12:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951253003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951253003/20001
4 years, 7 months ago (2016-05-05 14:16:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-05 15:05:27 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f1ef7ba0f99e5538922ae9c936ffba2138c8bdf9 Cr-Commit-Position: refs/heads/master@{#391803}
4 years, 7 months ago (2016-05-05 15:07:10 UTC) #12
gsennton
4 years, 7 months ago (2016-05-09 16:04:41 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1960203002/ by gsennton@chromium.org.

The reason for reverting is: Fix WebViewLayoutTest failures due to
https://codereview.chromium.org/1380503002 being reverted.

Reverting the current CL and  https://codereview.chromium.org/1950943002/ (that
revert is in https://codereview.chromium.org/1960923003/)

BUG=609448.

Powered by Google App Engine
This is Rietveld 408576698