Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1960763002: Remove unused PresubmitAddReviewers (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unused PresubmitAddReviewers R=dpranke@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300488

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M presubmit_support.py View 2 chunks +0 lines, -13 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dan Beam
4 years, 7 months ago (2016-05-06 21:27:44 UTC) #2
Dirk Pranke
how did you determine that no one was using this?
4 years, 7 months ago (2016-05-06 22:38:07 UTC) #3
Dan Beam
On 2016/05/06 22:38:07, Dirk Pranke wrote: > how did you determine that no one was ...
4 years, 7 months ago (2016-05-06 22:39:42 UTC) #4
Dirk Pranke
On 2016/05/06 22:39:42, Dan Beam wrote: > On 2016/05/06 22:38:07, Dirk Pranke wrote: > > ...
4 years, 7 months ago (2016-05-06 22:46:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960763002/20001
4 years, 7 months ago (2016-05-07 02:00:06 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 02:02:40 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300488

Powered by Google App Engine
This is Rietveld 408576698