Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: presubmit_support.py

Issue 1960763002: Remove unused PresubmitAddReviewers (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index 2c4d0eb7694c416c7296f54c7d22a33abb7e708e..249ec09367fd50659c910bc1d8ec29cf764704f7 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -158,18 +158,6 @@ class _PresubmitResult(object):
# Top level object so multiprocessing can pickle
# Public access through OutputApi object.
-class _PresubmitAddReviewers(_PresubmitResult):
- """Add some suggested reviewers to the change."""
- def __init__(self, reviewers):
- super(_PresubmitAddReviewers, self).__init__('')
- self.reviewers = reviewers
-
- def handle(self, output):
- output.reviewers.extend(self.reviewers)
-
-
-# Top level object so multiprocessing can pickle
-# Public access through OutputApi object.
class _PresubmitError(_PresubmitResult):
"""A hard presubmit error."""
fatal = True
@@ -270,7 +258,6 @@ class OutputApi(object):
can output various types of results.
"""
PresubmitResult = _PresubmitResult
- PresubmitAddReviewers = _PresubmitAddReviewers
PresubmitError = _PresubmitError
PresubmitPromptWarning = _PresubmitPromptWarning
PresubmitNotifyResult = _PresubmitNotifyResult
« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698