Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1960743002: Remove dependency of AsyncResourceLoader on content/browser/host_zoom_map_impl.h (Closed)

Created:
4 years, 7 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@devtoolsnetlog-loader
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of AsyncResourceLoader on c/b/host_zoom_map_impl.h This is accomplished by adding a ResourceDispatcherHostDelegate wrapper around the existing delegate that allows delegation from network back to content to do the content-specific functionality, before then delegating onwards to the existing content client (chrome). This new class is called ContentResourceDispatcherHostDelegate. Additionally, to be able to install the ContentResourceDispatcherHostDelegate, there's a ContentResourceDispatcherHost that wraps ResourceDispatcherHostImpl so that SetDelegate can wrap the new delegate around the existing one. After all that boilerplate, we can move the use of content/browser/host_zoom_map_impl.cc|h to ContentResourceDispatcherHostDelegate to avoid having c/b/loader use it in OnRequestStarted(). R=jam@chromium.org BUG=609607, 598073

Patch Set 1 #

Total comments: 1

Patch Set 2 : missed override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -84 lines) Patch
M content/browser/browser_main_loop.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A content/browser/content_resource_dispatcher_host.h View 1 chunk +41 lines, -0 lines 0 comments Download
A content/browser/content_resource_dispatcher_host.cc View 1 chunk +56 lines, -0 lines 0 comments Download
A + content/browser/content_resource_dispatcher_host_delegate.h View 1 2 chunks +17 lines, -54 lines 0 comments Download
A content/browser/content_resource_dispatcher_host_delegate.cc View 1 chunk +144 lines, -0 lines 0 comments Download
M content/browser/loader/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 3 chunks +8 lines, -11 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
scottmg
Not sure if this is too complicated for what it's accomplishing. wdyt? https://codereview.chromium.org/1960743002/diff/1/content/browser/content_resource_dispatcher_host_delegate.cc File content/browser/content_resource_dispatcher_host_delegate.cc ...
4 years, 7 months ago (2016-05-06 21:52:15 UTC) #2
scottmg
4 years, 6 months ago (2016-06-15 17:02:18 UTC) #3
closing as we're going another way (making the async mojo interface directly)

Powered by Google App Engine
This is Rietveld 408576698