Move DevToolsNetLogObserver to c/b/loader and create stub of network service interface

Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073, 607741
Committed: https://crrev.com/9d5bd76ba2a4ed19919a0f6b78e27b86ae64c9ee
Cr-Commit-Position: refs/heads/master@{#391958}

[scottmg, 2016-05-04 22:37:02]

Description was changed from

==========
Move DevToolsNetLogObserver to c/b/loader and create stub of network service
interface

BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to c/b/loader and create stub of network service
interface

Adds a simple stub of NetworkServiceInterface so that there's

BUG=598073,607741
==========

[scottmg, 2016-05-04 22:38:28]

Description was changed from

==========
Move DevToolsNetLogObserver to c/b/loader and create stub of network service
interface

Adds a simple stub of NetworkServiceInterface so that there's

BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to content/browser/loader

Adds a simple stub of NetworkServiceInterface so that there's somewhere
to consolidate an interface to //services/network in the future. But
it's just a silly wrapper for now. Doesn't move resource_devtools_info.h
yet, but I think we'll want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

[scottmg, 2016-05-04 23:02:59]

scottmg@chromium.org changed reviewers:
+ jam@chromium.org

[scottmg, 2016-05-04 23:02:59]

This is kind of a strawman just to start doing something. I'm not sure how we
want to set up the interface at this point, obviously this would just be a
temporary wrapper to try to define the eventual api that we could convert to
mojo.

Next steps for this particular change would be to figure out how to get a
ChromeNetLog instance without ContentClient(), and to probably embed
content/public/common/resource_devtools_info.h directly into
resource_response.h.

[jam, 2016-05-05 16:06:07]

https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
File content/browser/devtools/DEPS (right):

https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
content/browser/devtools/DEPS:7: "-content/browser/loader",
as a precursor for moving loading code out to services/network, we need the code
that will move to not include stuff from content.

we don't necessarily need code in content to only access the code that will be
moved via interfaces. that would add extra work for us to add wrappers. wdyt?

[scottmg, 2016-05-05 16:53:02]

https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
File content/browser/devtools/DEPS (right):

https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
content/browser/devtools/DEPS:7: "-content/browser/loader",
On 2016/05/05 16:06:07, jam wrote:
> as a precursor for moving loading code out to services/network, we need the
code
> that will move to not include stuff from content.
> 
> we don't necessarily need code in content to only access the code that will be
> moved via interfaces. that would add extra work for us to add wrappers. wdyt?

You mean just move it, but have content including things from
content/browser/loader still? I guess we could do that, but we're not going to
want content including things from //services/network, right? So you just want
to do it in two phases instead?

[jam, 2016-05-05 18:04:44]

On 2016/05/05 16:53:02, scottmg wrote:
>
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
> File content/browser/devtools/DEPS (right):
> 
>
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
> content/browser/devtools/DEPS:7: "-content/browser/loader",
> On 2016/05/05 16:06:07, jam wrote:
> > as a precursor for moving loading code out to services/network, we need the
> code
> > that will move to not include stuff from content.
> > 
> > we don't necessarily need code in content to only access the code that will
be
> > moved via interfaces. that would add extra work for us to add wrappers.
wdyt?
> 
> You mean just move it, but have content including things from
> content/browser/loader still?

correct. there's going to be enough work to do that as a first step, instead of
also adding a C++ API in-between which will be later replaced with mojo.

> I guess we could do that, but we're not going to
> want content including things from //services/network, right?

yep eventually

>  So you just want
> to do it in two phases instead?

right, just for scoping the work :) i suspect the first phase (just not having
services/network code include content/) is going to be a lot of work

[scottmg, 2016-05-05 19:19:06]

Patchset #4 (id:60001) has been deleted

[scottmg, 2016-05-05 19:20:31]

Description was changed from

==========
Move DevToolsNetLogObserver to content/browser/loader

Adds a simple stub of NetworkServiceInterface so that there's somewhere
to consolidate an interface to //services/network in the future. But
it's just a silly wrapper for now. Doesn't move resource_devtools_info.h
yet, but I think we'll want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to content/browser/loader

Adds a simple stub of NetworkServiceInterface so that there's somewhere
to consolidate an interface to //services/network in the future. But
it's just a silly wrapper for now. Doesn't move resource_devtools_info.h
yet, but I think we'll want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

[scottmg, 2016-05-05 19:20:51]

Description was changed from

==========
Move DevToolsNetLogObserver to content/browser/loader

Adds a simple stub of NetworkServiceInterface so that there's somewhere
to consolidate an interface to //services/network in the future. But
it's just a silly wrapper for now. Doesn't move resource_devtools_info.h
yet, but I think we'll want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

[scottmg, 2016-05-05 19:48:34]

On 2016/05/05 18:04:44, jam wrote:
> On 2016/05/05 16:53:02, scottmg wrote:
> >
>
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
> > File content/browser/devtools/DEPS (right):
> > 
> >
>
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtool...
> > content/browser/devtools/DEPS:7: "-content/browser/loader",
> > On 2016/05/05 16:06:07, jam wrote:
> > > as a precursor for moving loading code out to services/network, we need
the
> > code
> > > that will move to not include stuff from content.
> > > 
> > > we don't necessarily need code in content to only access the code that
will
> be
> > > moved via interfaces. that would add extra work for us to add wrappers.
> wdyt?
> > 
> > You mean just move it, but have content including things from
> > content/browser/loader still?
> 
> correct. there's going to be enough work to do that as a first step, instead
of
> also adding a C++ API in-between which will be later replaced with mojo.
> 
> > I guess we could do that, but we're not going to
> > want content including things from //services/network, right?
> 
> yep eventually
> 
> >  So you just want
> > to do it in two phases instead?
> 
> right, just for scoping the work :) i suspect the first phase (just not having
> services/network code include content/) is going to be a lot of work

OK, It just felt a bit half-assed because it doesn't really separate very much
yet in this case.

But I'm fine to start there and see how it goes. Removed
network_service_interface.* and let c/b/devtools include c/b/loader for now
then.

[jam, 2016-05-05 22:19:02]

lgtm

https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/...
File content/browser/loader/netlog_observer.h (right):

https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/...
content/browser/loader/netlog_observer.h:24: // may be of interest to DevTools.
Currently, this only includes actual
nit: rename devtools to say something like client?

[scottmg, 2016-05-05 22:24:29]

https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/...
File content/browser/loader/netlog_observer.h (right):

https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/...
content/browser/loader/netlog_observer.h:24: // may be of interest to DevTools.
Currently, this only includes actual
On 2016/05/05 22:19:02, jam wrote:
> nit: rename devtools to say something like client?

Oops, done.

[scottmg, 2016-05-05 22:24:34]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-05-05 22:24:34]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1953593002/#ps100001
(title: "fix comment")

[commit-bot: I haz the power, 2016-05-05 22:25:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1953593002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1953593002/100001

[commit-bot: I haz the power, 2016-05-06 00:05:33]

Description was changed from

==========
Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

[commit-bot: I haz the power, 2016-05-06 00:05:34]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-05-06 00:07:59]

Description was changed from

==========
Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073,607741
==========

to

==========
Move DevToolsNetLogObserver to content/browser/loader

Doesn't move resource_devtools_info.h yet, but I think we'll
want to do that.

R=jam@chromium.org
BUG=598073,607741

Committed: https://crrev.com/9d5bd76ba2a4ed19919a0f6b78e27b86ae64c9ee
Cr-Commit-Position: refs/heads/master@{#391958}
==========

[commit-bot: I haz the power, 2016-05-06 00:08:00]

Patchset 5 (id:??) landed as
https://crrev.com/9d5bd76ba2a4ed19919a0f6b78e27b86ae64c9ee
Cr-Commit-Position: refs/heads/master@{#391958}