Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 1953593002: Move DevToolsNetLogObserver to c/b/loader and create stub of network service interface (Closed)

Created:
4 years, 7 months ago by scottmg
Modified:
4 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move DevToolsNetLogObserver to content/browser/loader Doesn't move resource_devtools_info.h yet, but I think we'll want to do that. R=jam@chromium.org BUG=598073, 607741 Committed: https://crrev.com/9d5bd76ba2a4ed19919a0f6b78e27b86ae64c9ee Cr-Commit-Position: refs/heads/master@{#391958}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 2

Patch Set 4 : . #

Total comments: 2

Patch Set 5 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -329 lines) Patch
M content/browser/devtools/devtools_manager.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
D content/browser/devtools/devtools_netlog_observer.h View 1 chunk +0 lines, -65 lines 0 comments Download
D content/browser/devtools/devtools_netlog_observer.cc View 1 chunk +0 lines, -207 lines 0 comments Download
M content/browser/loader/DEPS View 1 2 5 chunks +13 lines, -3 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/loader/navigation_resource_handler.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/loader/netlog_observer.h View 1 2 3 4 4 chunks +16 lines, -17 lines 0 comments Download
A + content/browser/loader/netlog_observer.cc View 6 chunks +16 lines, -23 lines 0 comments Download
M content/browser/loader/sync_resource_handler.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (10 generated)
scottmg
This is kind of a strawman just to start doing something. I'm not sure how ...
4 years, 7 months ago (2016-05-04 23:02:59 UTC) #4
jam
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS File content/browser/devtools/DEPS (right): https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS#newcode7 content/browser/devtools/DEPS:7: "-content/browser/loader", as a precursor for moving loading code out ...
4 years, 7 months ago (2016-05-05 16:06:07 UTC) #5
scottmg
https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS File content/browser/devtools/DEPS (right): https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS#newcode7 content/browser/devtools/DEPS:7: "-content/browser/loader", On 2016/05/05 16:06:07, jam wrote: > as a ...
4 years, 7 months ago (2016-05-05 16:53:02 UTC) #6
jam
On 2016/05/05 16:53:02, scottmg wrote: > https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS > File content/browser/devtools/DEPS (right): > > https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS#newcode7 > ...
4 years, 7 months ago (2016-05-05 18:04:44 UTC) #7
scottmg
On 2016/05/05 18:04:44, jam wrote: > On 2016/05/05 16:53:02, scottmg wrote: > > > https://codereview.chromium.org/1953593002/diff/40001/content/browser/devtools/DEPS ...
4 years, 7 months ago (2016-05-05 19:48:34 UTC) #11
jam
lgtm https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/netlog_observer.h File content/browser/loader/netlog_observer.h (right): https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/netlog_observer.h#newcode24 content/browser/loader/netlog_observer.h:24: // may be of interest to DevTools. Currently, ...
4 years, 7 months ago (2016-05-05 22:19:02 UTC) #12
scottmg
https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/netlog_observer.h File content/browser/loader/netlog_observer.h (right): https://codereview.chromium.org/1953593002/diff/80001/content/browser/loader/netlog_observer.h#newcode24 content/browser/loader/netlog_observer.h:24: // may be of interest to DevTools. Currently, this ...
4 years, 7 months ago (2016-05-05 22:24:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1953593002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1953593002/100001
4 years, 7 months ago (2016-05-05 22:25:01 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 7 months ago (2016-05-06 00:05:34 UTC) #18
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 00:08:00 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9d5bd76ba2a4ed19919a0f6b78e27b86ae64c9ee
Cr-Commit-Position: refs/heads/master@{#391958}

Powered by Google App Engine
This is Rietveld 408576698