xfa/fde/fde_gedevice.h - Issue 1960673003: Replace some calls to Release() with direct delete, part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fde/fde_gedevice.h

Issue 1960673003: Replace some calls to Release() with direct delete, part 1. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Another unique_ptr. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: xfa/fde/fde_gedevice.h

diff --git a/xfa/fde/fde_gedevice.h b/xfa/fde/fde_gedevice.h

index 3d14a0f8af2cd993056cd450f40659e68d228d68..f69e4d106ca665e358b051ce52b5f7ffeb2bd978 100644

--- a/xfa/fde/fde_gedevice.h

+++ b/xfa/fde/fde_gedevice.h

@@ -21,9 +21,7 @@ class IFX_Font;

class CFDE_RenderDevice : public CFX_Target {

public:

CFDE_RenderDevice(CFX_RenderDevice* pDevice, FX_BOOL bOwnerDevice);

- ~CFDE_RenderDevice();

- void Release() { delete this; }

+ ~CFDE_RenderDevice() override;

int32_t GetWidth() const;

int32_t GetHeight() const;

« no previous file with comments | « xfa/fde/css/fde_csssyntax.h ('k') | xfa/fde/fde_iterator.h » ('j') | no next file with comments »