Issue 196063003: Don't use -rc versions of gerrit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196063003: Don't use -rc versions of gerrit. (Closed)

Created:
6 years, 9 months ago by szager1

Modified:
6 years, 9 months ago

Reviewers:
davidjames, Vadim Sh.

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Don't use -rc versions of gerrit. This is an emergency patch to avoid picking up the upcoming 2.9-rc0 version of gerrit, which requires java 7 and will break the chromeos bots. BUG=346369 R=davidjames@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256378

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	testing_support/gerrit-init.sh	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

davidjames

LGTM but please add a comment explaining why to the code as well :)

6 years, 9 months ago (2014-03-12 00:47:54 UTC) #1

Message was sent while issue was closed.

Committed patchset #3 manually as r256378.