Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: testing_support/gerrit-init.sh

Issue 196063003: Don't use -rc versions of gerrit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: code doc Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing_support/gerrit-init.sh
diff --git a/testing_support/gerrit-init.sh b/testing_support/gerrit-init.sh
index 706534728afb3d4a62524c2ad3f7412e9fd1695b..a969f98b5e5889de5b46b8f9554f73b043c4a7cb 100755
--- a/testing_support/gerrit-init.sh
+++ b/testing_support/gerrit-init.sh
@@ -88,8 +88,12 @@ def _cmp(a, b):
an.append('0')
while len(bn) < len(an):
bn.append('0')
- an.append(a[2][3:] if a[2] else '1000')
- bn.append(b[2][3:] if b[2] else '1000')
+# Disable using -rc versions. This is a temporary hack to avoid
+# picking up version 2.9-rc0, which requires java 7. These lines
+# should be un-commented after this bug is fixed:
+# https://code.google.com/p/chromium/issues/detail?id=346369
+# an.append(a[2][3:] if a[2] else '1000')
+# bn.append(b[2][3:] if b[2] else '1000')
for i in range(len(an)):
if an[i] != bn[i]:
return -1 if int(an[i]) > int(bn[i]) else 1
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698