Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 196053009: Web Animations API: Constructing an Animation from a partial keyframe throws a JS exception (Closed)

Created:
6 years, 9 months ago by rjwright
Modified:
6 years, 9 months ago
Reviewers:
dstockwell, shans
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, Inactive, darktears, arv+blink, Steve Block, dino_apple.com, watchdog-blink-watchlist_google.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@SyntheticKeyframesFix
Visibility:
Public.

Description

Web Animations API: Constructing an Animation from a partial keyframe throws a JS exception Depends on https://codereview.chromium.org/203463009/ Previously associated with issue https://codereview.chromium.org/190763007/ Previously, if an animation was constructed with a partial keyframe (a keyframe list with no keyframe at offset zero or no keyframe at offset one for any of the properties it declares) the renderer would crash. This change detects partial keyframes and throws a NotSupportedError in the JavaScript. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -42 lines) Patch
M LayoutTests/web-animations-api/element-animate-list-of-keyframes.html View 1 chunk +2 lines, -4 lines 0 comments Download
A LayoutTests/web-animations-api/partial-keyframes.html View 1 chunk +131 lines, -0 lines 0 comments Download
M Source/core/animation/Animation.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/animation/Animation.cpp View 2 chunks +7 lines, -6 lines 0 comments Download
M Source/core/animation/Animation.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 10 chunks +97 lines, -13 lines 0 comments Download
M Source/core/animation/EffectInput.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/animation/EffectInput.cpp View 2 chunks +6 lines, -2 lines 0 comments Download
M Source/core/animation/ElementAnimation.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/animation/ElementAnimation.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/KeyframeEffectModel.h View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/animation/KeyframeEffectModel.cpp View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rjwright
6 years, 9 months ago (2014-03-19 07:42:53 UTC) #1
ptal

Powered by Google App Engine
This is Rietveld 408576698