Source/core/animation/Animation.h - Issue 196053009: Web Animations API: Constructing an Animation from a partial keyframe throws a JS exception

Side by Side Diff: Source/core/animation/Animation.h

Issue 196053009: Web Animations API: Constructing an Animation from a partial keyframe throws a JS exception (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@SyntheticKeyframesFix

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/web-animations-api/partial-keyframes.html ('k') | Source/core/animation/Animation.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 22 matching lines...) Expand all Loading...
33	33

34 #include "core/animation/AnimationEffect.h"	34 #include "core/animation/AnimationEffect.h"

35 #include "core/animation/EffectInput.h"	35 #include "core/animation/EffectInput.h"

36 #include "core/animation/TimedItem.h"	36 #include "core/animation/TimedItem.h"

37 #include "core/animation/TimingInput.h"	37 #include "core/animation/TimingInput.h"

38 #include "heap/Handle.h"	38 #include "heap/Handle.h"

39 #include "wtf/RefPtr.h"	39 #include "wtf/RefPtr.h"

40	40

41 namespace WebCore {	41 namespace WebCore {

42	42

	43 class Dictionary;

43 class Element;	44 class Element;

44 class Dictionary;	45 class ExceptionState;

45	46

46 class Animation FINAL : public TimedItem {	47 class Animation FINAL : public TimedItem {

47	48

48 public:	49 public:

49 enum Priority { DefaultPriority, TransitionPriority };	50 enum Priority { DefaultPriority, TransitionPriority };

50	51

51 static PassRefPtr<Animation> create(PassRefPtr<Element>, PassRefPtrWillBeRaw Ptr<AnimationEffect>, const Timing&, Priority = DefaultPriority, PassOwnPtr<Even tDelegate> = nullptr);	52 static PassRefPtr<Animation> create(PassRefPtr<Element>, PassRefPtrWillBeRaw Ptr<AnimationEffect>, const Timing&, Priority = DefaultPriority, PassOwnPtr<Even tDelegate> = nullptr);

52 // Web Animations API Bindings constructors.	53 // Web Animations API Bindings constructors.

53 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>, const Dictionary& timingInputDictionary);	54 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>, const Dictionary& timingInputDictionary);

54 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>, double duration);	55 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>, double duration);

55 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>);	56 static PassRefPtr<Animation> create(Element*, PassRefPtrWillBeRawPtr<Animati onEffect>);

56 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector, const Dictionary& timingInputDictionary);	57 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector, const Dictionary& timingInputDictionary, ExceptionState&);

57 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector, double duration);	58 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector, double duration, ExceptionState&);

58 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector);	59 static PassRefPtr<Animation> create(Element*, const Vector<Dictionary>& keyf rameDictionaryVector, ExceptionState&);

59	60

60 // FIXME: Move all of these setter methods out of Animation,	61 // FIXME: Move all of these setter methods out of Animation,

61 // possibly into a new class (TimingInput?).	62 // possibly into a new class (TimingInput?).

62 static void setStartDelay(Timing&, double startDelay);	63 static void setStartDelay(Timing&, double startDelay);

63 static void setEndDelay(Timing&, double endDelay);	64 static void setEndDelay(Timing&, double endDelay);

64 static void setFillMode(Timing&, String fillMode);	65 static void setFillMode(Timing&, String fillMode);

65 static void setIterationStart(Timing&, double iterationStart);	66 static void setIterationStart(Timing&, double iterationStart);

66 static void setIterationCount(Timing&, double iterationCount);	67 static void setIterationCount(Timing&, double iterationCount);

67 static void setIterationDuration(Timing&, double iterationDuration);	68 static void setIterationDuration(Timing&, double iterationDuration);

68 static void setPlaybackRate(Timing&, double playbackRate);	69 static void setPlaybackRate(Timing&, double playbackRate);

(...skipping 46 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
115	116

116 friend class CSSAnimations;	117 friend class CSSAnimations;

117 friend class AnimationAnimationV8Test;	118 friend class AnimationAnimationV8Test;

118 };	119 };

119	120

120 DEFINE_TYPE_CASTS(Animation, TimedItem, timedItem, timedItem->isAnimation(), tim edItem.isAnimation());	121 DEFINE_TYPE_CASTS(Animation, TimedItem, timedItem, timedItem->isAnimation(), tim edItem.isAnimation());

121	122

122 } // namespace WebCore	123 } // namespace WebCore

123	124

124 #endif	125 #endif

OLD	NEW