Chromium Code Reviews
Help | Chromium Project | Sign in
(3)

Issue 1960423002: Reland of Mark the Certly.io log as disqualified, as of April 15 2016 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 months, 3 weeks ago by Ryan Sleevi (conf till 3-24)
Modified:
10 months, 3 weeks ago
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, cbentzel+watch_chromium.org, Eran Messeri
Base URL:
https://chromium.googlesource.com/chromium/src.git@log_diversity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Mark the Certly.io log as disqualified, as of April 15 2016 (patchset #2 id:140001 of https://codereview.chromium.org/1956273003/ ) Reason for revert: Unreverting; test failure was unrelated. Original issue's description: > Revert of Mark the Certly.io log as disqualified, as of April 15 2016 (patchset #6 id:90001 of https://codereview.chromium.org/1941273002/ ) > > Reason for revert: > This seems to be the most likely cause of this CertVerifyProcTest failure: > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/34273 > > Original issue's description: > > Mark the Certly.io log as disqualified, as of April 15 2016 > > > > BUG=none > > > > Committed: https://crrev.com/4db616c441f693e7eca3c7f5f7452fdfd4b84eb2 > > Cr-Commit-Position: refs/heads/master@{#392444} > > TBR=eroman@chromium.org,eranm@chromium.org,rsleevi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=none > > Committed: https://crrev.com/4036d8cfb59821cd3411004851e934a3b3293dfc > Cr-Commit-Position: refs/heads/master@{#392502} TBR=eroman@chromium.org,eranm@chromium.org,paulmiller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/3a88dbdb7a0c79942e1b0bc9c4f754961c470f28 Cr-Commit-Position: refs/heads/master@{#392514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -15 lines) Patch
M net/cert/ct_known_logs.h View 2 chunks +18 lines, -1 line 0 comments Download
M net/cert/ct_known_logs.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M net/cert/ct_known_logs_static-inc.h View 3 chunks +36 lines, -7 lines 0 comments Download
M net/cert/ct_policy_enforcer.cc View 2 chunks +25 lines, -5 lines 0 comments Download
M net/cert/ct_policy_enforcer_unittest.cc View 2 chunks +140 lines, -2 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (1 generated)
Ryan Sleevi (conf till 3-24)
Created Reland of Mark the Certly.io log as disqualified, as of April 15 2016
10 months, 3 weeks ago (2016-05-10 01:51:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960423002/1
10 months, 3 weeks ago (2016-05-10 01:51:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
10 months, 3 weeks ago (2016-05-10 01:52:09 UTC) #3
commit-bot: I haz the power
10 months, 3 weeks ago (2016-05-10 01:54:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a88dbdb7a0c79942e1b0bc9c4f754961c470f28
Cr-Commit-Position: refs/heads/master@{#392514}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46