Issue 1960303002: [Merge] Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1960303002: [Merge] Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by … (Closed)

Created:
4 years, 7 months ago by anthonyvd

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

[Merge] Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by adding a tint of rgba(0, 0, 0, .12) over the existing background color when the buttons are focused. BUG=604350, 595349 Review-Url: https://codereview.chromium.org/1910953003 Cr-Commit-Position: refs/heads/master@{#390465} (cherry picked from commit aa33561a9697af09418ce35fb5876aea79256307) Committed: https://chromium.googlesource.com/chromium/src/+/f3d436671fb176c76a4253f49aa0c0a4403c5ab7

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	chrome/browser/resources/sync_confirmation/sync_confirmation.css	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	chrome/browser/resources/sync_confirmation/sync_confirmation.html	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

anthonyvd

4 years, 7 months ago (2016-05-09 19:38:06 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f3d436671fb176c76a4253f49aa0c0a4403c5ab7.