Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 1910953003: Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog. (Closed)

Created:
4 years, 8 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes the broken focus issue of 'OK, GOT IT' and 'UNDO' in the sync confirmation dialog by adding a tint of rgba(0, 0, 0, .12) over the existing background color when the buttons are focused. BUG=604350, 595349 Committed: https://crrev.com/aa33561a9697af09418ce35fb5876aea79256307 Cr-Commit-Position: refs/heads/master@{#390465}

Patch Set 1 #

Patch Set 2 : 12% black tint over the background instead of the bold text #

Patch Set 3 : Addressed Michael's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/browser/resources/sync_confirmation/sync_confirmation.css View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/sync_confirmation/sync_confirmation.html View 1 2 2 chunks +22 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
Moe
Hi Dan, Could you please take a look at this?
4 years, 8 months ago (2016-04-21 18:34:19 UTC) #3
Dan Beam
lgtm but `bold` looks bad :(
4 years, 8 months ago (2016-04-21 18:44:10 UTC) #4
Moe
Dan, it should look a lot nicer now. This patch also fixes the spacing between ...
4 years, 8 months ago (2016-04-22 15:11:33 UTC) #5
Moe
Hi Dan, I replaced Patch #2 with an updated one with "cleaner" css. This patch ...
4 years, 7 months ago (2016-04-27 18:32:26 UTC) #7
michaelpg
lgtm but: 1. change the description (not bold anymore) On 2016/04/27 18:32:26, Moe wrote: > ...
4 years, 7 months ago (2016-04-28 19:20:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910953003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910953003/60001
4 years, 7 months ago (2016-04-28 20:32:20 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-04-28 20:38:29 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:20:45 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/aa33561a9697af09418ce35fb5876aea79256307
Cr-Commit-Position: refs/heads/master@{#390465}

Powered by Google App Engine
This is Rietveld 408576698