Remove OS_CHROMEOS from ui/ash code

Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357
Committed: https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c
Cr-Commit-Position: refs/heads/master@{#392580}

[oshima, 2016-05-09 19:11:15]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 19:11:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/1

[commit-bot: I haz the power, 2016-05-09 19:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 19:18:00]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[oshima, 2016-05-09 19:56:31]

Patchset #3 (id:40001) has been deleted

[oshima, 2016-05-09 19:56:35]

Patchset #2 (id:20001) has been deleted

[oshima, 2016-05-09 19:56:42]

Patchset #2 (id:60001) has been deleted

[oshima, 2016-05-09 19:56:48]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 19:57:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/80001

[oshima, 2016-05-09 21:00:18]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-05-09 21:03:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:03:43]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-05-09 21:12:55]

Description was changed from

==========
Cleanup

BUG=
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

BUG=610357
==========

[oshima, 2016-05-09 21:13:05]

Patchset #1 (id:80001) has been deleted

[oshima, 2016-05-09 21:13:13]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 21:13:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/100001

[oshima, 2016-05-09 21:14:30]

Description was changed from

==========
Remove OS_CHROMEOS from ui/ash code

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from c/b/ui/ash code

BUG=610357
==========

[oshima, 2016-05-09 21:15:34]

Description was changed from

==========
Remove OS_CHROMEOS from c/b/ui/ash code

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_unittest because app_list on desktop is no longer used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

BUG=610357
==========

[commit-bot: I haz the power, 2016-05-09 21:16:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 21:16:33]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2016-05-09 21:17:36]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2016-05-09 21:17:43]

Patchset #1 (id:100001) has been deleted

[commit-bot: I haz the power, 2016-05-09 21:18:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/120001

[oshima, 2016-05-09 21:19:38]

oshima@chromium.org changed reviewers:
+ msw@chromium.org, rockot@chromium.org, xiyuan@chromium.org

[oshima, 2016-05-09 21:21:07]

Description was changed from

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_unittest because app_list on desktop is no longer used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

BUG=610357
==========

[oshima, 2016-05-09 21:38:33]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-09 21:39:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/140001

[oshima, 2016-05-09 21:39:12]

rockot@ -> c/b/extensions
msw@ -> rest
xiyuan@ -> app_list_shower_views_unittest removal

[oshima, 2016-05-09 21:39:20]

Patchset #1 (id:120001) has been deleted

[oshima, 2016-05-09 21:41:45]

Description was changed from

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357
==========

[Ken Rockot(use gerrit already), 2016-05-09 22:13:50]

rs lgtm

[xiyuan, 2016-05-09 22:19:16]

app_list_shower_views_unittest removal LGTM

[commit-bot: I haz the power, 2016-05-09 22:35:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 22:35:32]

Dry run: This issue passed the CQ dry run.

[msw, 2016-05-09 22:42:50]

lgtm with minor comments.

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_shower_views_unittest.cc (left):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_shower_views_unittest.cc:1: // Copyright
2014 The Chromium Authors. All rights reserved.
nit: maybe wait to remove this with the implementation files?

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/ash_util.h (right):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/ash_util.h:8: #include "ui/gfx/native_widget_types.h"
nit: remove

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/system_tray_delegate_common.cc (left):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/system_tray_delegate_common.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
Odd that this file is marked as modified, not removed...

[oshima, 2016-05-09 23:08:41]

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/app_...
File chrome/browser/ui/app_list/app_list_shower_views_unittest.cc (left):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/app_...
chrome/browser/ui/app_list/app_list_shower_views_unittest.cc:1: // Copyright
2014 The Chromium Authors. All rights reserved.
On 2016/05/09 22:42:49, msw wrote:
> nit: maybe wait to remove this with the implementation files?

This file simply does not make sense in chromeos, and obsolete, so I decided to
simply remove it in stead of just excluding it on chromeos. I've got lgtm from
owner.

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/ash_util.h (right):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/ash_util.h:8: #include "ui/gfx/native_widget_types.h"
On 2016/05/09 22:42:50, msw wrote:
> nit: remove

Done.

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
File chrome/browser/ui/ash/system_tray_delegate_common.cc (left):

https://codereview.chromium.org/1960293003/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/system_tray_delegate_common.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2016/05/09 22:42:49, msw wrote:
> Odd that this file is marked as modified, not removed...

Yes, I noticed that, but I couldn't figure out how to fix it in rietveld. It'll
make sure it's removed when landed.

[oshima, 2016-05-09 23:08:55]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-05-09 23:08:56]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
msw@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1960293003/#ps160001
(title: " ")

[commit-bot: I haz the power, 2016-05-09 23:09:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/160001

[commit-bot: I haz the power, 2016-05-09 23:13:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-09 23:13:20]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[oshima, 2016-05-09 23:36:10]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-05-09 23:36:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
msw@chromium.org, xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1960293003/#ps180001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-09 23:36:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/180001

[commit-bot: I haz the power, 2016-05-10 01:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 01:39:50]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[oshima, 2016-05-10 10:44:40]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2016-05-10 10:44:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1960293003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1960293003/180001

[commit-bot: I haz the power, 2016-05-10 11:25:13]

Description was changed from

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357
==========

[commit-bot: I haz the power, 2016-05-10 11:25:16]

Committed patchset #3 (id:180001)

[commit-bot: I haz the power, 2016-05-10 11:26:31]

Description was changed from

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357
==========

to

==========
Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer
used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG=610357

Committed: https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c
Cr-Commit-Position: refs/heads/master@{#392580}
==========

[commit-bot: I haz the power, 2016-05-10 11:26:33]

Patchset 3 (id:??) landed as
https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c
Cr-Commit-Position: refs/heads/master@{#392580}