Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: chrome/browser/ui/app_list/app_list_shower_views_unittest.cc

Issue 1960293003: Remove OS_CHROMEOS from ui/ash code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/ash/accelerator_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/app_list/app_list_shower_views_unittest.cc
diff --git a/chrome/browser/ui/app_list/app_list_shower_views_unittest.cc b/chrome/browser/ui/app_list/app_list_shower_views_unittest.cc
deleted file mode 100644
index 9da5fb35b6f5deedfd5903bbc617ce1bd9d4ba91..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/app_list/app_list_shower_views_unittest.cc
+++ /dev/null
@@ -1,163 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/app_list/app_list_shower_views.h"
-
-#include "base/files/file_path.h"
-#include "base/macros.h"
-#include "base/memory/ptr_util.h"
-#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/app_list/app_list_shower_delegate.h"
-#include "chrome/browser/ui/app_list/test/fake_profile.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace {
-
-class FakeAppListShower : public AppListShower {
- public:
- explicit FakeAppListShower(AppListShowerDelegate* delegate)
- : AppListShower(delegate), has_view_(false), visible_(false) {}
-
- void ShowForProfile(Profile* requested_profile) {
- CreateViewForProfile(requested_profile);
- ShowForCurrentProfile();
- }
-
- // AppListShower:
- void HandleViewBeingDestroyed() override {
- AppListShower::HandleViewBeingDestroyed();
- has_view_ = false;
- visible_ = false;
- }
-
- bool IsAppListVisible() const override { return visible_; }
-
- app_list::AppListView* MakeViewForCurrentProfile() override {
- has_view_ = true;
- return NULL;
- }
-
- void UpdateViewForNewProfile() override {}
-
- void Show() override { visible_ = true; }
-
- void Hide() override { visible_ = false; }
-
- bool HasView() const override { return has_view_; }
-
- private:
- bool has_view_;
- bool visible_;
-
- DISALLOW_COPY_AND_ASSIGN(FakeAppListShower);
-};
-
-} // namespace
-
-class AppListShowerUnitTest : public testing::Test,
- public AppListShowerDelegate {
- public:
- AppListShowerUnitTest()
- : views_created_(0),
- views_dismissed_(0) {}
-
- void SetUp() override {
- shower_.reset(new FakeAppListShower(this));
- profile1_ = CreateProfile("p1");
- profile2_ = CreateProfile("p2");
- }
-
- void TearDown() override {}
-
- std::unique_ptr<FakeProfile> CreateProfile(const std::string& name) {
- return base::WrapUnique(new FakeProfile(name));
- }
-
- // AppListShowerDelegate:
- AppListViewDelegate* GetViewDelegateForCreate() override { return NULL; }
-
- bool HasKeepAlive() const {
- return shower_->keep_alive_.get() != NULL;
- }
-
- void OnViewCreated() override { ++views_created_; }
- void OnViewDismissed() override { ++views_dismissed_; }
- void MoveNearCursor(app_list::AppListView* view) override {}
-
- protected:
- std::unique_ptr<FakeAppListShower> shower_;
- std::unique_ptr<FakeProfile> profile1_;
- std::unique_ptr<FakeProfile> profile2_;
-
- int views_created_;
- int views_dismissed_;
-};
-
-TEST_F(AppListShowerUnitTest, Preconditions) {
- EXPECT_FALSE(shower_->IsAppListVisible());
- EXPECT_FALSE(shower_->HasView());
- EXPECT_FALSE(HasKeepAlive());
-}
-
-TEST_F(AppListShowerUnitTest, ShowForProfilePutsViewOnScreen) {
- shower_->ShowForProfile(profile1_.get());
- EXPECT_TRUE(shower_->IsAppListVisible());
- EXPECT_TRUE(shower_->HasView());
- EXPECT_TRUE(HasKeepAlive());
-}
-
-TEST_F(AppListShowerUnitTest, HidingViewRemovesKeepalive) {
- shower_->ShowForProfile(profile1_.get());
- shower_->DismissAppList();
- EXPECT_FALSE(shower_->IsAppListVisible());
- EXPECT_TRUE(shower_->HasView());
- EXPECT_FALSE(HasKeepAlive());
-}
-
-TEST_F(AppListShowerUnitTest, HideAndShowReusesView) {
- EXPECT_EQ(0, views_created_);
- shower_->ShowForProfile(profile1_.get());
- EXPECT_EQ(1, views_created_);
- EXPECT_EQ(0, views_dismissed_);
- shower_->DismissAppList();
- EXPECT_EQ(1, views_dismissed_);
- shower_->ShowForProfile(profile1_.get());
- EXPECT_EQ(1, views_created_);
-}
-
-TEST_F(AppListShowerUnitTest, CloseAndShowRecreatesView) {
- shower_->ShowForProfile(profile1_.get());
- shower_->HandleViewBeingDestroyed();
- // Destroying implies hiding. A separate notification shouldn't go out.
- EXPECT_EQ(0, views_dismissed_);
- shower_->ShowForProfile(profile1_.get());
- EXPECT_EQ(2, views_created_);
-}
-
-TEST_F(AppListShowerUnitTest, CloseRemovesView) {
- shower_->ShowForProfile(profile1_.get());
- shower_->HandleViewBeingDestroyed();
- EXPECT_FALSE(shower_->IsAppListVisible());
- EXPECT_FALSE(shower_->HasView());
- EXPECT_FALSE(HasKeepAlive());
-}
-
-TEST_F(AppListShowerUnitTest, CloseAppListClearsProfile) {
- EXPECT_EQ(NULL, shower_->profile());
- shower_->ShowForProfile(profile1_.get());
- EXPECT_EQ(profile1_.get(), shower_->profile());
- shower_->HandleViewBeingDestroyed();
- EXPECT_EQ(NULL, shower_->profile());
-}
-
-TEST_F(AppListShowerUnitTest, SwitchingProfiles) {
- shower_->ShowForProfile(profile1_.get());
- EXPECT_EQ("p1", shower_->profile()->GetProfileUserName());
- shower_->ShowForProfile(profile2_.get());
- EXPECT_EQ("p2", shower_->profile()->GetProfileUserName());
-
- // Shouldn't create new view for second profile - it should switch in place.
- EXPECT_EQ(1, views_created_);
- EXPECT_EQ(0, views_dismissed_);
-}
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/ash/accelerator_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698