Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1960263002: bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled. (Closed)

Created:
4 years, 7 months ago by scheib
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled. BUG=605326, 584113 TEST=To verify: Check the following with chrome launched with command line flag: --enable-blink-features=ExperimentalFramework On a Chrome OS device and an Android device: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Not Present Use Web Bluetooth Bluetooth Unavailable 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Not Present Use Web Bluetooth Bluetooth Unavailable On a Linux, OSX and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Not Present Use Web Bluetooth Bluetooth Unavailable 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Not Present Use Web Bluetooth Bluetooth Unavailable Check the following with chrome launched with command line flags: --enable-blink-features=ExperimentalFramework --enable-web-bluetooth On a Chrome OS, Android, Linux, OSX, and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Present Use Web Bluetooth Bluetooth Works On a Chrome OS, Android, Linux, OSX, and Windows devices: 1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html 2. Press the "Run Test" button. Expect: Web Bluetooth bindings Present Use Web Bluetooth Bluetooth Works Review-Url: https://codereview.chromium.org/1917313002 Cr-Commit-Position: refs/heads/master@{#390198} (cherry picked from commit 865f2de76200b7bf8362d4bd6ee9b7de2de3058e) Committed: https://chromium.googlesource.com/chromium/src/+/917f6d0b356ed63a6edd62b07b1595c99d2781a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -38 lines) Patch
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/Bluetooth.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAdvertisingData.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothCharacteristicProperties.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
scheib
4 years, 7 months ago (2016-05-09 18:58:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
917f6d0b356ed63a6edd62b07b1595c99d2781a7.

Powered by Google App Engine
This is Rietveld 408576698