bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113
TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

Committed: https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e
Cr-Commit-Position: refs/heads/master@{#390198}

[scheib, 2016-04-26 23:15:18]

Description was changed from

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326
==========

to

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326

TEST=To verify

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

[scheib, 2016-04-26 23:15:18]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-04-26 23:36:44]

lgtm with one question.

https://codereview.chromium.org/1917313002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl (right):

https://codereview.chromium.org/1917313002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl:15: //
RuntimeEnabled=WebBluetooth
This should be OriginTrialEnabled right?

[scheib, 2016-04-27 00:43:55]

scheib@chromium.org changed reviewers:
+ dglazkov@chromium.org

[scheib, 2016-04-27 00:43:55]

Thanks.

dglazkov, OWNERS:
LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
Source/platform/RuntimeEnabledFeatures.in
Source/web/WebLocalFrameImpl.cpp

https://codereview.chromium.org/1917313002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl (right):

https://codereview.chromium.org/1917313002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.idl:15: //
RuntimeEnabled=WebBluetooth
On 2016/04/26 23:36:44, ortuno wrote:
> This should be OriginTrialEnabled right?

Done.

[dglazkov, 2016-04-27 03:59:08]

lgtm

https://codereview.chromium.org/1917313002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/1917313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:1482: // enableWebBluetooth
= true;
Could we remove the commented-out code? We try not to land it like that.

[scheib, 2016-04-27 04:09:32]

Description was changed from

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326

TEST=To verify

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

to

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

[scheib, 2016-04-27 04:13:07]

Thanks

[scheib, 2016-04-27 04:13:12]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-04-27 04:13:13]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
dglazkov@chromium.org
Link to the patchset: https://codereview.chromium.org/1917313002/#ps40001
(title: "Remove commented out code.")

[commit-bot: I haz the power, 2016-04-27 04:13:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917313002/40001

[scheib, 2016-04-27 04:13:34]

https://codereview.chromium.org/1917313002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebLocalFrameImpl.cpp (right):

https://codereview.chromium.org/1917313002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebLocalFrameImpl.cpp:1482: // enableWebBluetooth
= true;
On 2016/04/27 03:59:08, dglazkov wrote:
> Could we remove the commented-out code? We try not to land it like that.

Done.

[commit-bot: I haz the power, 2016-04-27 04:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 04:22:33]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[scheib, 2016-04-27 04:33:08]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-04-27 04:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917313002/40001

[commit-bot: I haz the power, 2016-04-27 04:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-27 04:51:59]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[scheib, 2016-04-27 20:28:24]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-04-27 20:28:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1917313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1917313002/40001

[commit-bot: I haz the power, 2016-04-27 21:39:45]

Description was changed from

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

to

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

[commit-bot: I haz the power, 2016-04-27 21:39:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-30 17:13:28]

Patchset 3 (id:??) landed as
https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e
Cr-Commit-Position: refs/heads/master@{#390198}

[commit-bot: I haz the power, 2016-04-30 17:52:08]

Description was changed from

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable


Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works
==========

to

==========
bluetooth: Move Web Bluetooth from OriginTrialEnabled to RuntimeEnabled.

BUG=605326, 584113

TEST=To verify:

Check the following with chrome launched with command line flag:
  --enable-blink-features=ExperimentalFramework

On a Chrome OS device and an Android device:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

On a Linux, OSX and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Not Present
 Use Web Bluetooth	Bluetooth Unavailable

Check the following with chrome launched with command line flags:
 --enable-blink-features=ExperimentalFramework --enable-web-bluetooth

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

On a Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
 Expect:
 Web Bluetooth bindings	Present
 Use Web Bluetooth	Bluetooth Works

Committed: https://crrev.com/865f2de76200b7bf8362d4bd6ee9b7de2de3058e
Cr-Commit-Position: refs/heads/master@{#390198}
==========