Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3048)

Unified Diff: Source/modules/screen_orientation/ScreenOrientation.h

Issue 196023016: Oilpan: move Screen and its supplement to the oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/screen_orientation/ScreenOrientation.h
diff --git a/Source/modules/screen_orientation/ScreenOrientation.h b/Source/modules/screen_orientation/ScreenOrientation.h
index ff5a85f657c4f7ed402d025143a03af0ac38f008..c8ba48bc810c09e309af56ad7a42a772510b453a 100644
--- a/Source/modules/screen_orientation/ScreenOrientation.h
+++ b/Source/modules/screen_orientation/ScreenOrientation.h
@@ -7,6 +7,7 @@
#include "core/events/EventTarget.h"
#include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
#include "platform/Supplementable.h"
#include "platform/Timer.h"
#include "public/platform/WebScreenOrientation.h"
@@ -19,7 +20,8 @@ namespace WebCore {
class Document;
class Screen;
-class ScreenOrientation FINAL : public Supplement<Screen>, DOMWindowProperty {
+class ScreenOrientation FINAL : public NoBaseWillBeGarbageCollectedFinalized<ScreenOrientation>, public WillBeHeapSupplement<Screen>, DOMWindowProperty {
+ WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientation);
public:
static ScreenOrientation& from(Screen&);
virtual ~ScreenOrientation();
@@ -31,6 +33,8 @@ public:
static bool lockOrientation(Screen&, const AtomicString& orientation);
static void unlockOrientation(Screen&);
+ virtual void trace(Visitor*) { }
haraken 2014/03/14 11:39:45 Don't you need to trace WillBeHeapSupplement::trac
zerny-chromium 2014/03/14 11:54:48 Yes. I missed that one. The ToT plugin should catc
sof 2014/03/14 12:01:31 Why? Isn't that the method that's implemented here
+
private:
explicit ScreenOrientation(Screen&);

Powered by Google App Engine
This is Rietveld 408576698