Oilpan: move Screen and its supplement to the oilpan heap.

Source/modules/screen_orientation/ScreenOrientation.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ScreenOrientation_h
 #define ScreenOrientation_h
 
 #include "core/events/EventTarget.h"
 #include "core/frame/DOMWindowProperty.h"
+#include "heap/Handle.h"
 #include "platform/Supplementable.h"
 #include "platform/Timer.h"
 #include "public/platform/WebScreenOrientation.h"
 #include "wtf/Vector.h"
 #include "wtf/text/AtomicString.h"
 #include "wtf/text/WTFString.h"
 
 namespace WebCore {
 
 class Document;
 class Screen;
 
-class ScreenOrientation FINAL : public Supplement<Screen>, DOMWindowProperty {
+class ScreenOrientation FINAL : public NoBaseWillBeGarbageCollectedFinalized<ScreenOrientation>, public WillBeHeapSupplement<Screen>, DOMWindowProperty {
+    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(ScreenOrientation);
 public:
     static ScreenOrientation& from(Screen&);
     virtual ~ScreenOrientation();
 
     DEFINE_STATIC_ATTRIBUTE_EVENT_LISTENER(orientationchange);
 
     static const AtomicString& orientation(Screen&);
     static bool lockOrientation(Screen&, const Vector<String>& orientations);
     static bool lockOrientation(Screen&, const AtomicString& orientation);
     static void unlockOrientation(Screen&);
 
+    virtual void trace(Visitor*) { }

[haraken, 2014/03/14 11:39:45]

Don't you need to trace WillBeHeapSupplement::trace() ?

[zerny-chromium, 2014/03/14 11:54:48]

Yes. I missed that one. The ToT plugin should catch this one (trying out a local
build now)

[sof, 2014/03/14 12:01:31]

Why? Isn't that the method that's implemented here?

+
 private:
     explicit ScreenOrientation(Screen&);
 
     void lockOrientationAsync(blink::WebScreenOrientations);
     void orientationLockTimerFired(Timer<ScreenOrientation>*);
 
     static const char* supplementName();
     Document* document() const;
 
     Timer<ScreenOrientation> m_orientationLockTimer;
     blink::WebScreenOrientations m_lockedOrientations;
 };
 
 } // namespace WebCore
 
 #endif // ScreenOrientation_h