Issue 196015: Try again to fix bug 20968, this time not breaking browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 196015: Try again to fix bug 20968, this time not breaking browser (Closed)

Created:
11 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Try again to fix bug 20968, this time not breaking browser tests. This is kinda a janky hack to get the browser test to keep working but I couldn't think of anything better. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25402

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -7 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/test/data/extensions/samples/subscribe_page_action/background.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html	View	2 chunks	+8 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

11 years, 3 months ago (2009-09-03 23:04:22 UTC) #2

I love it. :)

http://codereview.chromium.org/196015/diff/1/4
File chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
(right):

http://codereview.chromium.org/196015/diff/1/4#newcode8
Line 8: // Grab the URL from the querystring, removing question mark at the
front.
nit: The question mark comment now applies to the line above this line...

Expand Messages | Collapse Messages