Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 196015: Try again to fix bug 20968, this time not breaking browser (Closed)

Created:
11 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Try again to fix bug 20968, this time not breaking browser tests. This is kinda a janky hack to get the browser test to keep working but I couldn't think of anything better. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25402

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M chrome/browser/extensions/extension_browsertests_misc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/samples/subscribe_page_action/background.html View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html View 2 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
11 years, 3 months ago (2009-09-03 22:57:54 UTC) #1
Finnur
11 years, 3 months ago (2009-09-03 23:04:22 UTC) #2
I love it. :)

http://codereview.chromium.org/196015/diff/1/4
File chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html
(right):

http://codereview.chromium.org/196015/diff/1/4#newcode8
Line 8: // Grab the URL from the querystring, removing question mark at the
front.
nit: The question mark comment now applies to the line above this line...

Powered by Google App Engine
This is Rietveld 408576698