chrome/test/data/extensions/samples/subscribe_page_action/background.html - Issue 196015: Try again to fix bug 20968, this time not breaking browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/samples/subscribe_page_action/background.html

Issue 196015: Try again to fix bug 20968, this time not breaking browser (Closed)

Patch Set: Created 11 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_browsertests_misc.cc ('k') | chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html » ('j') | chrome/test/data/extensions/samples/subscribe_page_action/subscribe.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/samples/subscribe_page_action/background.html

diff --git a/chrome/test/data/extensions/samples/subscribe_page_action/background.html b/chrome/test/data/extensions/samples/subscribe_page_action/background.html

index a8a0902417a0cea4d9885a0e639937f6bff2231a..9ab4f3f61521e913a54da89252470e9134131307 100644

--- a/chrome/test/data/extensions/samples/subscribe_page_action/background.html

+++ b/chrome/test/data/extensions/samples/subscribe_page_action/background.html

@@ -43,9 +43,9 @@

if (window.focused) {

// Create a new tab showing the subscription page with the right

// feed URL.

- chrome.tabs.create({url: "subscribe.html?" +

- feedData[pageActionInfo.tabId].feedUrl,

- windowId: window.windowId});

+ var url = "subscribe.html?" +

+ encodeURIComponent(feedData[pageActionInfo.tabId].feedUrl);

+ chrome.tabs.create({url: url, windowId: window.windowId});

}

});