Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issue 1960083002: [fullcodegen] Add missing bailout points for super calls. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Add missing bailout points for super calls. The bailout points for named and keyed property loads when doing super property calls are not being prepared by full-codegen, even though we are using them in TurboFan for deopts and stack traces. R=jarin@chromium.org TEST=mjsunit/regress/regress-4971 BUG=v8:4971 LOG=n Committed: https://crrev.com/afb69f7438760e3cd07d6393057edee784c078bb Cr-Commit-Position: refs/heads/master@{#36109}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-4971.js View 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-09 13:12:30 UTC) #1
Jarin
lgtm. Thanks!
4 years, 7 months ago (2016-05-09 13:23:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960083002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960083002/1
4 years, 7 months ago (2016-05-09 13:24:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-09 13:43:54 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 13:44:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afb69f7438760e3cd07d6393057edee784c078bb
Cr-Commit-Position: refs/heads/master@{#36109}

Powered by Google App Engine
This is Rietveld 408576698