Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1960083002: [fullcodegen] Add missing bailout points for super calls. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 2299 matching lines...) Expand 10 before | Expand all | Expand 10 after
2310 PushOperand(Operand(rsp, kPointerSize * 2)); 2310 PushOperand(Operand(rsp, kPointerSize * 2));
2311 PushOperand(key->value()); 2311 PushOperand(key->value());
2312 2312
2313 // Stack here: 2313 // Stack here:
2314 // - home_object 2314 // - home_object
2315 // - this (receiver) 2315 // - this (receiver)
2316 // - this (receiver) <-- LoadFromSuper will pop here and below. 2316 // - this (receiver) <-- LoadFromSuper will pop here and below.
2317 // - home_object 2317 // - home_object
2318 // - key 2318 // - key
2319 CallRuntimeWithOperands(Runtime::kLoadFromSuper); 2319 CallRuntimeWithOperands(Runtime::kLoadFromSuper);
2320 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
2320 2321
2321 // Replace home_object with target function. 2322 // Replace home_object with target function.
2322 __ movp(Operand(rsp, kPointerSize), rax); 2323 __ movp(Operand(rsp, kPointerSize), rax);
2323 2324
2324 // Stack here: 2325 // Stack here:
2325 // - target function 2326 // - target function
2326 // - this (receiver) 2327 // - this (receiver)
2327 EmitCall(expr); 2328 EmitCall(expr);
2328 } 2329 }
2329 2330
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
2367 PushOperand(Operand(rsp, kPointerSize * 2)); 2368 PushOperand(Operand(rsp, kPointerSize * 2));
2368 VisitForStackValue(prop->key()); 2369 VisitForStackValue(prop->key());
2369 2370
2370 // Stack here: 2371 // Stack here:
2371 // - home_object 2372 // - home_object
2372 // - this (receiver) 2373 // - this (receiver)
2373 // - this (receiver) <-- LoadKeyedFromSuper will pop here and below. 2374 // - this (receiver) <-- LoadKeyedFromSuper will pop here and below.
2374 // - home_object 2375 // - home_object
2375 // - key 2376 // - key
2376 CallRuntimeWithOperands(Runtime::kLoadKeyedFromSuper); 2377 CallRuntimeWithOperands(Runtime::kLoadKeyedFromSuper);
2378 PrepareForBailoutForId(prop->LoadId(), TOS_REG);
2377 2379
2378 // Replace home_object with target function. 2380 // Replace home_object with target function.
2379 __ movp(Operand(rsp, kPointerSize), rax); 2381 __ movp(Operand(rsp, kPointerSize), rax);
2380 2382
2381 // Stack here: 2383 // Stack here:
2382 // - target function 2384 // - target function
2383 // - this (receiver) 2385 // - this (receiver)
2384 EmitCall(expr); 2386 EmitCall(expr);
2385 } 2387 }
2386 2388
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
3847 DCHECK_EQ( 3849 DCHECK_EQ(
3848 isolate->builtins()->OnStackReplacement()->entry(), 3850 isolate->builtins()->OnStackReplacement()->entry(),
3849 Assembler::target_address_at(call_target_address, unoptimized_code)); 3851 Assembler::target_address_at(call_target_address, unoptimized_code));
3850 return ON_STACK_REPLACEMENT; 3852 return ON_STACK_REPLACEMENT;
3851 } 3853 }
3852 3854
3853 } // namespace internal 3855 } // namespace internal
3854 } // namespace v8 3856 } // namespace v8
3855 3857
3856 #endif // V8_TARGET_ARCH_X64 3858 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698