Source/modules/gamepad/GamepadList.h - Issue 195993007: Factor out GamepadCommon base class from Gamepad and WebKitGamepad

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/gamepad/GamepadList.h

Issue 195993007: Factor out GamepadCommon base class from Gamepad and WebKitGamepad (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add ABC FIXME Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/gamepad/GamepadList.h

diff --git a/Source/modules/gamepad/GamepadList.h b/Source/modules/gamepad/GamepadList.h

index b19e6afc5c042d2e2ff471da76bf39ceb9734733..57415d93be75df0a6ed1abf99c7bce7941eeb69a 100644

--- a/Source/modules/gamepad/GamepadList.h

+++ b/Source/modules/gamepad/GamepadList.h

@@ -47,12 +47,15 @@ public:

void trace(Visitor*);

-private:

+protected:

+ // inherited by WebKitGamepadList

GamepadList()

{

ScriptWrappable::init(this);

}

+private:

+ // WebKitGamepadList items are of type WebKitGamepad, not Gamepad

haraken 2014/03/13 07:08:50 Remove this comment. Or move the comment to WebKit

RefPtrWillBeMember<Gamepad> m_items[blink::WebGamepads::itemsLengthCap];

};