Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 195983006: Constrain constant references from deferred libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('K') | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | tests/compiler/dart2js_extra/deferred/deferred_constant5_test.dart » ('j') | tests/language/deferred_constraints_constants_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/warnings.dart
diff --git a/sdk/lib/_internal/compiler/implementation/warnings.dart b/sdk/lib/_internal/compiler/implementation/warnings.dart
index a67dc21b274a89380d03f19bc7ebb1fce5200718..e5fdeb2ff5e14817877935aedc6b41ce0e29419c 100644
--- a/sdk/lib/_internal/compiler/implementation/warnings.dart
+++ b/sdk/lib/_internal/compiler/implementation/warnings.dart
@@ -554,7 +554,11 @@ main() => new C<String>();
"Not a compile-time constant.");
static const MessageKind DEFERRED_COMPILE_TIME_CONSTANT = const MessageKind(
- "Deferred classes cannot be used to create compile-time constants.");
+ "Deferred values cannot be used as compile-time constants.");
floitsch 2014/03/12 16:48:13 A deferred value ... constant. (singular).
+
+ static const MessageKind DEFERRED_COMPILE_TIME_CONSTANT_CONSTRUCTION =
+ const MessageKind("Deferred classes cannot be used to create "
floitsch 2014/03/12 16:48:13 ditto.
+ "compile-time constants.");
static const MessageKind CYCLIC_COMPILE_TIME_CONSTANTS = const MessageKind(
"Cycle in the compile-time constant computation.");
« sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('K') | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | tests/compiler/dart2js_extra/deferred/deferred_constant5_test.dart » ('j') | tests/language/deferred_constraints_constants_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698