Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/warnings.dart

Issue 195983006: Constrain constant references from deferred libraries (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js; 5 part of dart2js;
6 6
7 const DONT_KNOW_HOW_TO_FIX = ""; 7 const DONT_KNOW_HOW_TO_FIX = "";
8 8
9 /** 9 /**
10 * The messages in this file should meet the following guide lines: 10 * The messages in this file should meet the following guide lines:
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 const MessageKind( 547 const MessageKind(
548 "'case' expression type '#{type}' overrides 'operator =='."); 548 "'case' expression type '#{type}' overrides 'operator =='.");
549 549
550 static const MessageKind INVALID_ARGUMENT_AFTER_NAMED = const MessageKind( 550 static const MessageKind INVALID_ARGUMENT_AFTER_NAMED = const MessageKind(
551 "Unnamed argument after named argument."); 551 "Unnamed argument after named argument.");
552 552
553 static const MessageKind NOT_A_COMPILE_TIME_CONSTANT = const MessageKind( 553 static const MessageKind NOT_A_COMPILE_TIME_CONSTANT = const MessageKind(
554 "Not a compile-time constant."); 554 "Not a compile-time constant.");
555 555
556 static const MessageKind DEFERRED_COMPILE_TIME_CONSTANT = const MessageKind( 556 static const MessageKind DEFERRED_COMPILE_TIME_CONSTANT = const MessageKind(
557 "Deferred classes cannot be used to create compile-time constants."); 557 "Deferred values cannot be used as compile-time constants.");
floitsch 2014/03/12 16:48:13 A deferred value ... constant. (singular).
558
559 static const MessageKind DEFERRED_COMPILE_TIME_CONSTANT_CONSTRUCTION =
560 const MessageKind("Deferred classes cannot be used to create "
floitsch 2014/03/12 16:48:13 ditto.
561 "compile-time constants.");
558 562
559 static const MessageKind CYCLIC_COMPILE_TIME_CONSTANTS = const MessageKind( 563 static const MessageKind CYCLIC_COMPILE_TIME_CONSTANTS = const MessageKind(
560 "Cycle in the compile-time constant computation."); 564 "Cycle in the compile-time constant computation.");
561 565
562 static const MessageKind CONSTRUCTOR_IS_NOT_CONST = const MessageKind( 566 static const MessageKind CONSTRUCTOR_IS_NOT_CONST = const MessageKind(
563 "Constructor is not a 'const' constructor."); 567 "Constructor is not a 'const' constructor.");
564 568
565 static const MessageKind CONST_MAP_KEY_OVERRIDES_EQUALS = 569 static const MessageKind CONST_MAP_KEY_OVERRIDES_EQUALS =
566 const MessageKind( 570 const MessageKind(
567 "Const-map key type '#{type}' overrides 'operator =='."); 571 "Const-map key type '#{type}' overrides 'operator =='.");
(...skipping 1351 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 return computeMessage(); 1923 return computeMessage();
1920 } 1924 }
1921 1925
1922 bool operator==(other) { 1926 bool operator==(other) {
1923 if (other is !Message) return false; 1927 if (other is !Message) return false;
1924 return (kind == other.kind) && (toString() == other.toString()); 1928 return (kind == other.kind) && (toString() == other.toString());
1925 } 1929 }
1926 1930
1927 int get hashCode => throw new UnsupportedError('Message.hashCode'); 1931 int get hashCode => throw new UnsupportedError('Message.hashCode');
1928 } 1932 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698