chrome/common/logging_chrome.cc - Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/logging_chrome.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Keep a comment Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/logging_chrome.cc

diff --git a/chrome/common/logging_chrome.cc b/chrome/common/logging_chrome.cc

index be0ddffa1c533bd6c7ab46dd284cb54349a14752..a0b53f09c8dfc70380d936a1904374766f5f56ff 100644

--- a/chrome/common/logging_chrome.cc

+++ b/chrome/common/logging_chrome.cc

@@ -358,13 +358,10 @@ void InitChromeLogging(const CommandLine& command_line,

logging::LogEventProvider::Initialize(kChromeTraceProviderName);

#endif

-#ifdef NDEBUG

- if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK) && DCHECK_IS_ON()) {

-#if defined(OS_WIN)

+#if DCHECK_IS_ON && defined(NDEBUG) && defined(OS_WIN)

+ if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK))

logging::SetLogReportHandler(DumpProcessAssertHandler);

#endif

- }

-#endif // NDEBUG

chrome_logging_initialized_ = true;

}

« no previous file with comments | « chrome/browser/history/top_sites_cache.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »