Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: chrome/common/logging_chrome.cc

Issue 195973002: Change DCHECK_IS_ON() to DCHECK_IS_ON (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Keep a comment Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/top_sites_cache.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 // Need to include this before most other files because it defines 7 // Need to include this before most other files because it defines
8 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define 8 // IPC_MESSAGE_LOG_ENABLED. We need to use it to define
9 // IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the 9 // IPC_MESSAGE_MACROS_LOG_ENABLED so render_messages.h will generate the
10 // ViewMsgLog et al. functions. 10 // ViewMsgLog et al. functions.
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 } else { 351 } else {
352 DLOG(WARNING) << "Bad log level: " << log_level; 352 DLOG(WARNING) << "Bad log level: " << log_level;
353 } 353 }
354 } 354 }
355 355
356 #if defined(OS_WIN) 356 #if defined(OS_WIN)
357 // Enable trace control and transport through event tracing for Windows. 357 // Enable trace control and transport through event tracing for Windows.
358 logging::LogEventProvider::Initialize(kChromeTraceProviderName); 358 logging::LogEventProvider::Initialize(kChromeTraceProviderName);
359 #endif 359 #endif
360 360
361 #ifdef NDEBUG 361 #if DCHECK_IS_ON && defined(NDEBUG) && defined(OS_WIN)
362 if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK) && DCHECK_IS_ON()) { 362 if (command_line.HasSwitch(switches::kSilentDumpOnDCHECK))
363 #if defined(OS_WIN)
364 logging::SetLogReportHandler(DumpProcessAssertHandler); 363 logging::SetLogReportHandler(DumpProcessAssertHandler);
365 #endif 364 #endif
366 }
367 #endif // NDEBUG
368 365
369 chrome_logging_initialized_ = true; 366 chrome_logging_initialized_ = true;
370 } 367 }
371 368
372 // This is a no-op, but we'll keep it around in case 369 // This is a no-op, but we'll keep it around in case
373 // we need to do more cleanup in the future. 370 // we need to do more cleanup in the future.
374 void CleanupChromeLogging() { 371 void CleanupChromeLogging() {
375 if (chrome_logging_failed_) 372 if (chrome_logging_failed_)
376 return; // We failed to initiailize logging, no cleanup. 373 return; // We failed to initiailize logging, no cleanup.
377 374
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 time_deets.year, 439 time_deets.year,
443 time_deets.month, 440 time_deets.month,
444 time_deets.day_of_month, 441 time_deets.day_of_month,
445 time_deets.hour, 442 time_deets.hour,
446 time_deets.minute, 443 time_deets.minute,
447 time_deets.second); 444 time_deets.second);
448 return base_path.InsertBeforeExtensionASCII(suffix); 445 return base_path.InsertBeforeExtensionASCII(suffix);
449 } 446 }
450 447
451 } // namespace logging 448 } // namespace logging
OLDNEW
« no previous file with comments | « chrome/browser/history/top_sites_cache.cc ('k') | chrome/installer/util/shell_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698