If a resource load is started as the CachedResourceLoader is going away, make sure we remove the Ca…

If a resource load is started as the CachedResourceLoader is going away, make sure we remove the CachedResource from the MemoryCache.

This was regressed in r149483.

BUG=257316
TEST=ResourceFetcherTest.StartLoadAfterFrameDetach

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154852

[Nate Chapin, 2013-07-23 23:13:17]

If you have ideas on how to layout tests this, I'm interested to hear them.

https://codereview.chromium.org/19597008/diff/1/Source/core/loader/cache/Cach...
File Source/core/loader/cache/CachedResourceLoader.cpp (right):

https://codereview.chromium.org/19597008/diff/1/Source/core/loader/cache/Cach...
Source/core/loader/cache/CachedResourceLoader.cpp:503: if (!frame() ||
m_documentLoader != frame()->loader()->activeDocumentLoader() ||
m_documentLoader->isStopping()) {
I believe the last 2 cases are a more succinct and equivalent to the deleted
if() statement below.

[abarth-chromium, 2013-07-23 23:21:56]

LGTM

If we had a most fleshed out unit testing harness for this code, we could
potentially use that to test this issue, but the test would probably wind up
being somewhat artificial...  Can you add your manual test to ManualTests?

[Nate Chapin, 2013-07-24 17:14:01]

On 2013/07/23 23:21:56, abarth wrote:
> LGTM
> 
> If we had a most fleshed out unit testing harness for this code, we could
> potentially use that to test this issue, but the test would probably wind up
> being somewhat artificial...  Can you add your manual test to ManualTests?

A unit test occurred to me after I went home yesterday. Updated the patch to
include it.

[abarth-chromium, 2013-07-24 19:55:08]

LGTM.  I'm a bit worried that this sort of test will make the code harder to
refactor, but we can cross that bridge when we come to it.

[commit-bot: I haz the power, 2013-07-24 19:55:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/19597008/11001

[commit-bot: I haz the power, 2013-07-24 22:35:20]

Change committed as 154852