Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Side by Side Diff: Source/core/loader/cache/ResourceFetcherTest.cpp

Issue 19597008: If a resource load is started as the CachedResourceLoader is going away, make sure we remove the Ca… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: + test Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/cache/ResourceFetcher.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 11 matching lines...) Expand all
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/animation/AnimatableNeutral.h" 32 #include "core/loader/cache/ResourceFetcher.h"
33 33
34 #include "core/animation/AnimatableUnknown.h" 34 #include "core/html/HTMLDocument.h"
35 #include "core/css/CSSArrayFunctionValue.h" 35 #include "core/loader/DocumentLoader.h"
36 36 #include "core/loader/cache/CachedResourceHandle.h"
37 #include "core/loader/cache/CachedResourceInitiatorInfo.h"
38 #include "core/loader/cache/FetchRequest.h"
39 #include "core/loader/cache/MemoryCache.h"
40 #include "core/platform/network/ResourceRequest.h"
37 #include <gtest/gtest.h> 41 #include <gtest/gtest.h>
38 42
39 using namespace WebCore; 43 using namespace WebCore;
40 44
41 namespace { 45 namespace {
42 46
43 TEST(AnimatableNeutral, Create) 47 TEST(ResourceFetcherTest, StartLoadAfterFrameDetach)
44 { 48 {
45 EXPECT_TRUE(AnimatableValue::neutralValue()); 49 KURL testURL(ParsedURLString, "http://www.test.com/cancelTest.jpg");
50
51 // Create a ResourceFetcher that has a real DocumentLoader and Document, but is not attached to a Frame.
52 // Technically, we're concerned about what happens after a Frame is detached (rather than before
53 // any attach occurs), but ResourceFetcher can't tell the difference.
54 RefPtr<DocumentLoader> documentLoader = DocumentLoader::create(ResourceReque st(testURL), SubstituteData());
55 RefPtr<HTMLDocument> document = HTMLDocument::create();
56 RefPtr<ResourceFetcher> fetcher(documentLoader->fetcher());
57 fetcher->setDocument(document.get());
58 EXPECT_EQ(fetcher->frame(), static_cast<Frame*>(0));
59
60 // Try to request a url. The request should fail, no resource should be retu rned,
61 // and no resource should be present in the cache.
62 FetchRequest fetchRequest = FetchRequest(ResourceRequest(testURL), CachedRes ourceInitiatorInfo());
63 CachedResourceHandle<CachedImage> image = fetcher->requestImage(fetchRequest );
64 EXPECT_EQ(image.get(), static_cast<CachedImage*>(0));
65 EXPECT_EQ(memoryCache()->resourceForURL(testURL), static_cast<CachedResource *>(0));
46 } 66 }
47 67
48 TEST(AnimatableNeutral, Add) 68 } // namespace
49 {
50 RefPtr<CSSValue> cssValue = CSSArrayFunctionValue::create();
51 RefPtr<AnimatableValue> animatableUnknown = AnimatableUnknown::create(cssVal ue);
52
53 EXPECT_EQ(cssValue, AnimatableValue::add(animatableUnknown.get(), Animatable Value::neutralValue())->toCSSValue());
54 EXPECT_EQ(cssValue, AnimatableValue::add(AnimatableValue::neutralValue(), an imatableUnknown.get())->toCSSValue());
55 }
56
57 }
OLDNEW
« no previous file with comments | « Source/core/loader/cache/ResourceFetcher.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698