Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1959583002: Do not open SELECT popup if the SELECT element is not in the viewport. (Closed)

Created:
4 years, 7 months ago by tkent
Modified:
4 years, 7 months ago
Reviewers:
keishi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not open SELECT popup if the SELECT element is not in the viewport. New behavior is compatible with IE and Firefox. The main parts of this CL are: - HTMLSelectElement.cpp, and - menulist-popup-outside-viewport.html Changes in other files are just adjustment for the new behavior. - ExternalPopupMenuTest.cpp: The viewport size was too small. - popup-menu-key-operations.html: PASS messages moved out a SELECT element - popup-menu-position.html: Anchor rectangle is clipped. BUG=90515, 565760 Committed: https://crrev.com/b82a8a7a80fa77005f996f93f60e4f32c8882651 Cr-Commit-Position: refs/heads/master@{#392240}

Patch Set 1 : #

Patch Set 2 : popup-menu-key-operations.html needs rebaseline #

Messages

Total messages: 12 (7 generated)
tkent
Keishi, would you review this please?
4 years, 7 months ago (2016-05-06 07:40:03 UTC) #5
keishi
LGTM
4 years, 7 months ago (2016-05-06 08:38:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959583002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959583002/60001
4 years, 7 months ago (2016-05-07 03:12:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 7 months ago (2016-05-07 03:18:14 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-07 03:20:14 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b82a8a7a80fa77005f996f93f60e4f32c8882651
Cr-Commit-Position: refs/heads/master@{#392240}

Powered by Google App Engine
This is Rietveld 408576698