third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html - Issue 1959583002: Do not open SELECT popup if the SELECT element is not in the viewport.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-key-operations.html

Issue 1959583002: Do not open SELECT popup if the SELECT element is not in the viewport. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: popup-menu-key-operations.html needs rebaseline Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/forms/select-popup/popup-menu-position.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <script src="../resources/common.js"></script>	5 <script src="../resources/common.js"></script>

6 <script src="../resources/picker-common.js"></script>	6 <script src="../resources/picker-common.js"></script>

7 </head>	7 </head>

8 <body>	8 <body>

9 <select id="menu">	9 <select id="menu">

10 <option>foo</option>	10 <option>foo</option>

11 <option selected>bar</option>	11 <option selected>bar</option>

12 <option hidden>baz</option>	12 <option hidden>baz</option>

13 <optgroup label="qux">	13 <optgroup label="qux">

14 <option>garply</option>	14 <option>garply</option>

15 </optgroup>	15 </optgroup>

16 </select>	16 </select>

	17 <div id="console"></div>

17 <script>	18 <script>

18 var menu = document.getElementById('menu');	19 var menu = document.getElementById('menu');

19 var picker = null;	20 var picker = null;

20 function openPickerErrorCallback() {	21 function openPickerErrorCallback() {

21 testFailed('picker didn\'t open')	22 testFailed('picker didn\'t open')

22 finishJSTest();	23 finishJSTest();

23 }	24 }

24 openPicker(menu, test1, openPickerErrorCallback);	25 openPicker(menu, test1, openPickerErrorCallback);

25	26

26 function test1() {	27 function test1() {

(...skipping 141 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
168 clickElement(picker._selectElement.children[0]);	169 clickElement(picker._selectElement.children[0]);

169 shouldBeNull('window.internals.pagePopupWindow');	170 shouldBeNull('window.internals.pagePopupWindow');

170 shouldBeEqualToString('menu.value', 'foo');	171 shouldBeEqualToString('menu.value', 'foo');

171 shouldBeEqualToString('internals.selectMenuListText(menu)', 'foo');	172 shouldBeEqualToString('internals.selectMenuListText(menu)', 'foo');

172	173

173 finishJSTest();	174 finishJSTest();

174 }	175 }

175 </script>	176 </script>

176 </body>	177 </body>

177 </html>	178 </html>

OLD	NEW