Issue 1959343002: Turn on SkCodecPrintf on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1959343002: Turn on SkCodecPrintf on Windows (Closed)

Created:
4 years, 7 months ago by scroggo_chromium

Modified:
4 years, 3 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@raw_win

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Turn on SkCodecPrintf on Windows Only for testing. I suspect the problem we're seeing is due to OOM. This will help to confirm that. BUG=skia:5283 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1959343002

Patch Set 1 #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/common_conditions.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Depends on Patchset:

Issue 1960153005 Patch 1

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scroggo_chromium

4 years, 7 months ago (2016-05-10 13:43:11 UTC) #1

Description was changed from

==========
Turn on SkCodecPrintf on Windows

Only for testing. I suspect the problem we're seeing is due to
OOM. This will help to confirm that.

BUG=skia:5283
==========

to

==========
Turn on SkCodecPrintf on Windows

Only for testing. I suspect the problem we're seeing is due to
OOM. This will help to confirm that.

BUG=skia:5283
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages