Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Issue 1959153003: Revert of Add CHECK in case PathProviderAndroid is failing. (Closed)

Created:
4 years, 7 months ago by falken
Modified:
4 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add CHECK in case PathProviderAndroid is failing. (patchset #2 id:20001 of https://codereview.chromium.org/1914983002/ ) Reason for revert: We got enough crash reports, reverting now. Original issue's description: > Add CHECK in case PathProviderAndroid is failing. > > In bug 600226, RenderProcessHost::Init() is returning > false. The only possible cause I can see is if the path > service returned false, so see if PathProviderAndroid > is returning false. > > BUG=600226 > > Committed: https://crrev.com/c1a595d1736123171d216b67535303916d95874d > Cr-Commit-Position: refs/heads/master@{#389468} TBR=torne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=600226 Committed: https://crrev.com/fa35291713d19ec1f47f59fd5ba6586a85ca1738 Cr-Commit-Position: refs/heads/master@{#392530}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M base/base_paths_android.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
falken
Created Revert of Add CHECK in case PathProviderAndroid is failing.
4 years, 7 months ago (2016-05-10 01:53:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959153003/1
4 years, 7 months ago (2016-05-10 01:53:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 02:55:57 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 02:57:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa35291713d19ec1f47f59fd5ba6586a85ca1738
Cr-Commit-Position: refs/heads/master@{#392530}

Powered by Google App Engine
This is Rietveld 408576698