Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1132)

Unified Diff: base/base_paths_android.cc

Issue 1959153003: Revert of Add CHECK in case PathProviderAndroid is failing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_paths_android.cc
diff --git a/base/base_paths_android.cc b/base/base_paths_android.cc
index 62b07dde07340f4d5a85071ff56d87f461ee0d2b..ca58179b6782fdc4d9ec283df14b4d97b5e688dc 100644
--- a/base/base_paths_android.cc
+++ b/base/base_paths_android.cc
@@ -23,11 +23,10 @@
case base::FILE_EXE: {
char bin_dir[PATH_MAX + 1];
int bin_dir_size = readlink(kProcSelfExe, bin_dir, PATH_MAX);
- // TODO(falken): This PCHECK is for debugging crbug.com/600226.
- // Revert to NOTREACHED when the cause of the bug is understood.
- PCHECK(bin_dir_size > 0 && bin_dir_size <= PATH_MAX)
- << "Unable to resolve " << kProcSelfExe
- << ". bin_dir_size=" << bin_dir_size;
+ if (bin_dir_size < 0 || bin_dir_size > PATH_MAX) {
+ NOTREACHED() << "Unable to resolve " << kProcSelfExe << ".";
+ return false;
+ }
bin_dir[bin_dir_size] = 0;
*result = FilePath(bin_dir);
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698