Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1959143002: Move WebUSB from OriginTrialEnabled to RuntimeEnabled. (Closed)

Created:
4 years, 7 months ago by scheib
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Move WebUSB from OriginTrialEnabled to RuntimeEnabled. This reverses commit 5c00cb62536b679d52c3741598d3f08f79e7e32f. BUG=605326, 492204 TEST=To verify: On Windows, Chrome OS, Mac OSX: Check the following with chrome launched without command line flags: For each site: https://permission.site http://permission.site Load and press the USB button. Expect in Chrome Developer Tools: Console output: "Uncaught TypeError: Cannot read property 'requestDevice' of undefined" Check the following with chrome launched with command line flag: --enable-blink-features=ExperimentalFramework For https://permission.site Load and press the USB button. Expect a chooser dialog to open. For http://permission.site Load and press the USB button. Expect in Chrome Developer Tools: Console output: "error usb DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV)." Review-Url: https://codereview.chromium.org/1917103004 Cr-Commit-Position: refs/heads/master@{#391090} (cherry picked from commit 403af928b91df81acac1fc3b27fc093f2eb6da24) Committed: https://chromium.googlesource.com/chromium/src/+/499429ab56d93c5e90c338fdb6d42e9987b3e508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBOutTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
scheib
4 years, 7 months ago (2016-05-09 19:14:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
499429ab56d93c5e90c338fdb6d42e9987b3e508.

Powered by Google App Engine
This is Rietveld 408576698