Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1917103004: Move WebUSB from OriginTrialEnabled to RuntimeEnabled. (Closed)

Created:
4 years, 8 months ago by scheib
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, haraken, jam, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebUSB from OriginTrialEnabled to RuntimeEnabled. This reverses commit 5c00cb62536b679d52c3741598d3f08f79e7e32f. BUG=605326, 492204 TEST=To verify: On Windows, Chrome OS, Mac OSX: Check the following with chrome launched without command line flags: For each site: https://permission.site http://permission.site Load and press the USB button. Expect in Chrome Developer Tools: Console output: "Uncaught TypeError: Cannot read property 'requestDevice' of undefined" Check the following with chrome launched with command line flag: --enable-blink-features=ExperimentalFramework For https://permission.site Load and press the USB button. Expect a chooser dialog to open. For http://permission.site Load and press the USB button. Expect in Chrome Developer Tools: Console output: "error usb DOMException: Only secure origins are allowed (see: https://goo.gl/Y0ZkNV)." Committed: https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24 Cr-Commit-Position: refs/heads/master@{#391090}

Patch Set 1 #

Patch Set 2 : merge TOT #

Total comments: 2

Patch Set 3 : correct content/public/common/content_features.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -31 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/NavigatorUSB.idl View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USB.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBAlternateInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConfiguration.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConnectionEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBEndpoint.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferPacket.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousInTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferPacket.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBIsochronousOutTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBOutTransferResult.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
scheib
reillyg, on Bluetooth we have a test page setup to verify changes such as this. ...
4 years, 8 months ago (2016-04-27 00:30:13 UTC) #3
scheib
PTAL
4 years, 7 months ago (2016-04-28 01:12:57 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 7 months ago (2016-04-28 18:32:31 UTC) #6
scheib
Thanks, jochen for OWNERS of non .idl files please.
4 years, 7 months ago (2016-04-28 21:07:46 UTC) #8
jochen (gone - plz use gerrit)
lgtm with comment https://codereview.chromium.org/1917103004/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/1917103004/diff/20001/content/renderer/render_frame_impl.cc#oldcode67 content/renderer/render_frame_impl.cc:67: #include "content/public/common/content_features.h" Unrelated?
4 years, 7 months ago (2016-05-02 17:09:46 UTC) #9
scheib
Thanks https://codereview.chromium.org/1917103004/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (left): https://codereview.chromium.org/1917103004/diff/20001/content/renderer/render_frame_impl.cc#oldcode67 content/renderer/render_frame_impl.cc:67: #include "content/public/common/content_features.h" On 2016/05/02 17:09:46, jochen wrote: > ...
4 years, 7 months ago (2016-05-02 19:38:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1917103004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1917103004/40001
4 years, 7 months ago (2016-05-02 19:39:22 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 23:28:49 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:30:33 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/403af928b91df81acac1fc3b27fc093f2eb6da24
Cr-Commit-Position: refs/heads/master@{#391090}

Powered by Google App Engine
This is Rietveld 408576698