Issue 19591003: Add purgeAsNeeded calls before addResource calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19591003: Add purgeAsNeeded calls before addResource calls (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

It looks like a caller can arbitrarily exceed the cache limit by just issuing a series of drawBitmapRect calls with a new uploaded texture each time. This change (with the new IODB flushing capability) allows the cache to at least remain close to its budget.

Patch Set 1 #

Patch Set 2 : added extraCount & extraSize to account for future memory requirements #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -9 lines)			Patch
M	src/gpu/GrContext.cpp	View	1	3 chunks	+7 lines, -1 line	0 comments	Download
M	src/gpu/GrResourceCache.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/gpu/GrResourceCache.cpp	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

LGTM. Can you file a bug to precompute the resource size and purge the cache ...

7 years, 5 months ago (2013-07-17 17:55:59 UTC) #3

robertphillips

Created: Move resource cache purging before allocation (rather than before insertion) https://code.google.com/p/skia/issues/detail?id=1429

7 years, 5 months ago (2013-07-17 18:02:46 UTC) #4

committed as r10145 & 10146

Expand Messages | Collapse Messages