Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1959093004: Roll media/cdm/api deps (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
Reviewers:
pcc1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll media/cdm/api deps. This CL brings fixes for visibility of types used across Chromium->CDM bridge. See https://chromiumcodereview.appspot.com/1956123002/ and https://codereview.chromium.org/1964083003/ Also, removing now unnecessary lines in CFI blacklist. BUG=609564, 609175, 515347 Committed: https://crrev.com/c5197d2ab04247a33e6934b576cdbd071ba562c2 Cr-Commit-Position: refs/heads/master@{#393981}

Patch Set 1 #

Patch Set 2 : roll media/cdm/api deps #

Patch Set 3 : also delete mojo types from blacklist #

Patch Set 4 : sync #

Patch Set 5 : fix windows with CDM_CLASS_API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M tools/cfi/blacklist.txt View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959093004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959093004/20001
4 years, 7 months ago (2016-05-10 05:47:28 UTC) #3
krasin
4 years, 7 months ago (2016-05-10 05:48:37 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/2891) ios-simulator on ...
4 years, 7 months ago (2016-05-10 05:49:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959093004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959093004/60001
4 years, 7 months ago (2016-05-10 05:54:11 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/187501)
4 years, 7 months ago (2016-05-10 06:36:42 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959093004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959093004/80001
4 years, 7 months ago (2016-05-16 22:08:32 UTC) #14
krasin
Peter, please, take a look. Trybots are green.
4 years, 7 months ago (2016-05-16 22:59:49 UTC) #15
pcc1
lgtm
4 years, 7 months ago (2016-05-16 23:05:36 UTC) #16
krasin
Xiaohan, just an FYI: I am bumping media/cdm/api deps. Things look good so far.
4 years, 7 months ago (2016-05-16 23:10:42 UTC) #18
xhwang
On 2016/05/16 23:10:42, krasin wrote: > Xiaohan, > > just an FYI: I am bumping ...
4 years, 7 months ago (2016-05-16 23:15:49 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-16 23:35:51 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959093004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959093004/80001
4 years, 7 months ago (2016-05-16 23:40:25 UTC) #23
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-16 23:44:20 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 23:46:07 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c5197d2ab04247a33e6934b576cdbd071ba562c2
Cr-Commit-Position: refs/heads/master@{#393981}

Powered by Google App Engine
This is Rietveld 408576698