Fix warning when closing a proxy that passed its handle.

Fix comment on Interface close.

The behavior is different between implementations and proxies.

R=ppi@chromium.org, ppi

Committed: https://chromium.googlesource.com/external/mojo/+/c07399d071c59658a5c2bed81dee6e9ed9142442

[abarth, 2016-05-09 14:52:36]

abarth@google.com changed reviewers:
+ abarth@google.com

[abarth, 2016-05-09 14:52:37]

https://codereview.chromium.org/1959043002/diff/1/mojo/public/java/bindings/s...
File
mojo/public/java/bindings/src/org/chromium/mojo/bindings/AutoCloseableRouter.java
(right):

https://codereview.chromium.org/1959043002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/AutoCloseableRouter.java:53:
mClosed = true;
Can we avoid keeping this extra boolean and instead read this information from
the underlying handle inside the mRouter?  That's how the C++ bindings solve
this problem.

[qsr, 2016-05-09 14:54:49]

https://codereview.chromium.org/1959043002/diff/1/mojo/public/java/bindings/s...
File
mojo/public/java/bindings/src/org/chromium/mojo/bindings/AutoCloseableRouter.java
(right):

https://codereview.chromium.org/1959043002/diff/1/mojo/public/java/bindings/s...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/AutoCloseableRouter.java:53:
mClosed = true;
On 2016/05/09 14:52:37, abarth wrote:
> Can we avoid keeping this extra boolean and instead read this information from
> the underlying handle inside the mRouter?  That's how the C++ bindings solve
> this problem.

Not easily. The finalizer is run on its own thread, which is not the safe thread
to call any method on the router object.

[qsr, 2016-05-10 10:50:11]

Description was changed from

==========
Fix warning when closing a proxy that passed its handle.

Also fix comment on close to differenciate between implementations and proxies.

R=ppi
==========

to

==========
Fix comment on Interface close.

The behavior is different between implementations and proxies.

R=ppi
==========

[ppi, 2016-05-10 12:23:48]

lgtm

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
(right):

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:22: *
implementation is closed.
nit: should we say what the method is supposed to do in this case, too?

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:24: * If
the interface is a proxy, the close method will close the connection to the
nit: use present tense: "the close method closes the connection..."

[qsr, 2016-05-10 12:31:38]

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
File mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java
(right):

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:22: *
implementation is closed.
On 2016/05/10 12:23:48, ppi wrote:
> nit: should we say what the method is supposed to do in this case, too?

I don't think we can really do it. It really depends on the implementation,
given that it is possible for an implementation to bind to multiple pipes.

https://codereview.chromium.org/1959043002/diff/20001/mojo/public/java/bindin...
mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java:24: * If
the interface is a proxy, the close method will close the connection to the
On 2016/05/10 12:23:48, ppi wrote:
> nit: use present tense: "the close method closes the connection..."

Done.

[qsr, 2016-05-10 12:31:46]

Description was changed from

==========
Fix comment on Interface close.

The behavior is different between implementations and proxies.

R=ppi
==========

to

==========
Fix comment on Interface close.

The behavior is different between implementations and proxies.

R=ppi@chromium.org, ppi

Committed:
https://chromium.googlesource.com/external/mojo/+/c07399d071c59658a5c2bed81de...
==========

[qsr, 2016-05-10 12:31:48]

Committed patchset #3 (id:40001) manually as
c07399d071c59658a5c2bed81dee6e9ed9142442 (presubmit successful).